Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable using the plugin without .default #24

Conversation

dqn
Copy link

@dqn dqn commented Sep 3, 2020

Enable using this plugin without property access like .default.

// const HTMLInlineCSSWebpackPlugin = require("html-inline-css-webpack-plugin").default;
const HTMLInlineCSSWebpackPlugin = require("html-inline-css-webpack-plugin");

@runjuu
Copy link
Owner

runjuu commented Sep 3, 2020

Hi @dqn , It looks like a breaking change. Can it compatible with the old way ?

@dqn
Copy link
Author

dqn commented Sep 3, 2020

Hi @runjuu. You're right, it's a breaking change.
If you can merge it, maybe this change should be merged into another branch, such as a develop branch, so that people who see the README of this repository are not confused.

@github-actions
Copy link

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Nov 18, 2020
@github-actions github-actions bot closed this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants