[FLINK-24553][core] Changed buffer debloat default configuration valu…

…es to more optimal
ruslandanilin · Nov 1, 2021 · 4377612 · 4377612
1 parent 003df21
commit 4377612
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/docs/layouts/shortcodes/generated/all_taskmanager_network_section.html b/docs/layouts/shortcodes/generated/all_taskmanager_network_section.html
@@ -34,7 +34,7 @@
         </tr>
         <tr>
             <td><h5>taskmanager.network.memory.buffer-debloat.period</h5></td>
-            <td style="word-wrap: break-word;">500 ms</td>
+            <td style="word-wrap: break-word;">200 ms</td>
             <td>Duration</td>
             <td>The minimum period of time after which the buffer size will be debloated if required. The low value provides a fast reaction to the load fluctuation but can influence the performance.</td>
         </tr>
@@ -52,7 +52,7 @@
         </tr>
         <tr>
             <td><h5>taskmanager.network.memory.buffer-debloat.threshold-percentages</h5></td>
-            <td style="word-wrap: break-word;">50</td>
+            <td style="word-wrap: break-word;">25</td>
             <td>Integer</td>
             <td>The minimum difference in percentage between the newly calculated buffer size and the old one to announce the new value. Can be used to avoid constant back and forth small adjustments.</td>
         </tr>

diff --git a/docs/layouts/shortcodes/generated/all_taskmanager_section.html b/docs/layouts/shortcodes/generated/all_taskmanager_section.html
@@ -64,7 +64,7 @@
         </tr>
         <tr>
             <td><h5>taskmanager.memory.min-segment-size</h5></td>
-            <td style="word-wrap: break-word;">1 kb</td>
+            <td style="word-wrap: break-word;">256 bytes</td>
             <td>MemorySize</td>
             <td>Minimum possible size of memory buffers used by the network stack and the memory manager. ex. can be used for automatic buffer size adjustment.</td>
         </tr>

diff --git a/docs/layouts/shortcodes/generated/task_manager_configuration.html b/docs/layouts/shortcodes/generated/task_manager_configuration.html
@@ -71,7 +71,7 @@
         </tr>
         <tr>
             <td><h5>taskmanager.network.memory.buffer-debloat.period</h5></td>
-            <td style="word-wrap: break-word;">500 ms</td>
+            <td style="word-wrap: break-word;">200 ms</td>
             <td>Duration</td>
             <td>The minimum period of time after which the buffer size will be debloated if required. The low value provides a fast reaction to the load fluctuation but can influence the performance.</td>
         </tr>
@@ -89,7 +89,7 @@
         </tr>
         <tr>
             <td><h5>taskmanager.network.memory.buffer-debloat.threshold-percentages</h5></td>
-            <td style="word-wrap: break-word;">50</td>
+            <td style="word-wrap: break-word;">25</td>
             <td>Integer</td>
             <td>The minimum difference in percentage between the newly calculated buffer size and the old one to announce the new value. Can be used to avoid constant back and forth small adjustments.</td>
         </tr>

diff --git a/docs/layouts/shortcodes/generated/task_manager_memory_configuration.html b/docs/layouts/shortcodes/generated/task_manager_memory_configuration.html
@@ -76,7 +76,7 @@
         </tr>
         <tr>
             <td><h5>taskmanager.memory.min-segment-size</h5></td>
-            <td style="word-wrap: break-word;">1 kb</td>
+            <td style="word-wrap: break-word;">256 bytes</td>
             <td>MemorySize</td>
             <td>Minimum possible size of memory buffers used by the network stack and the memory manager. ex. can be used for automatic buffer size adjustment.</td>
         </tr>

diff --git a/flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java b/flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
@@ -289,7 +289,7 @@ public class TaskManagerOptions {
     public static final ConfigOption<MemorySize> MIN_MEMORY_SEGMENT_SIZE =
             key("taskmanager.memory.min-segment-size")
                     .memoryType()
-                    .defaultValue(MemorySize.parse("1kb"))
+                    .defaultValue(MemorySize.parse("256"))
                     .withDescription(
                             "Minimum possible size of memory buffers used by the network stack and the memory manager. "
                                     + "ex. can be used for automatic buffer size adjustment.");
@@ -534,7 +534,7 @@ public class TaskManagerOptions {
     public static final ConfigOption<Duration> BUFFER_DEBLOAT_PERIOD =
             ConfigOptions.key("taskmanager.network.memory.buffer-debloat.period")
                     .durationType()
-                    .defaultValue(Duration.ofMillis(500))
+                    .defaultValue(Duration.ofMillis(200))
                     .withDescription(
                             "The minimum period of time after which the buffer size will be debloated if required. "
                                     + "The low value provides a fast reaction to the load fluctuation but can influence the performance.");
@@ -574,7 +574,7 @@ public class TaskManagerOptions {
     public static final ConfigOption<Integer> BUFFER_DEBLOAT_THRESHOLD_PERCENTAGES =
             ConfigOptions.key("taskmanager.network.memory.buffer-debloat.threshold-percentages")
                     .intType()
-                    .defaultValue(50)
+                    .defaultValue(25)
                     .withDescription(
                             "The minimum difference in percentage between the newly calculated buffer size and the old one to announce the new value. "
                                     + "Can be used to avoid constant back and forth small adjustments.");