-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test on cygwin #4357
Fix test on cygwin #4357
Conversation
The tracking PR of |
@rustbot label +stable-nominated |
Just curious: when this PR is backported to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please squash
The patch gets backported as-is, is there any reason not to do that? This is acceptable breakage, correctness fix on a tier 3 target. |
Squashed.
Well, yes though... But other unix targets still use |
IMO correctness is preferred over consistency since hopefully 1.0 will be around later this year, better to go for correctness than add another divergence between the branches. (There are probably some exceptions, like the unfortunate pre- |
And fill semver file for cygwin.
Understood, thank you for your explanation. |
And fill semver file for cygwin. (backport <rust-lang#4357>) (cherry picked from commit 5c8804b)
Description
It's possible to run tests targeting cygwin now. It helps me to find some bugs.
Sources
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI
Reference