Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test on cygwin #4357

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Fix test on cygwin #4357

merged 1 commit into from
Apr 1, 2025

Conversation

Berrysoft
Copy link
Contributor

@Berrysoft Berrysoft commented Mar 30, 2025

Description

It's possible to run tests targeting cygwin now. It helps me to find some bugs.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Reference

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Berrysoft Berrysoft marked this pull request as ready for review March 31, 2025 09:09
@Berrysoft
Copy link
Contributor Author

The tracking PR of ctest2 is for tests, if you want a CI for cygwin target.

@tgross35
Copy link
Contributor

tgross35 commented Apr 1, 2025

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Apr 1, 2025
@Berrysoft Berrysoft requested a review from tgross35 April 1, 2025 07:49
@Berrysoft
Copy link
Contributor Author

Just curious: when this PR is backported to libc-0.2 branch, will the signature of execvpe and fexecve be changed?

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash

@tgross35
Copy link
Contributor

tgross35 commented Apr 1, 2025

Just curious: when this PR is backported to libc-0.2 branch, will the signature of execvpe and fexecve be changed?

The patch gets backported as-is, is there any reason not to do that? This is acceptable breakage, correctness fix on a tier 3 target.

@Berrysoft
Copy link
Contributor Author

Squashed.

This is acceptable breakage, correctness fix on a tier 3 target.

Well, yes though... But other unix targets still use *const *const c_char at this branch. Is it better to keep the consistency?

@tgross35
Copy link
Contributor

tgross35 commented Apr 1, 2025

Well, yes though... But other unix targets still use *const *const c_char at this branch. Is it better to keep the consistency?

IMO correctness is preferred over consistency since hopefully 1.0 will be around later this year, better to go for correctness than add another divergence between the branches. (There are probably some exceptions, like the unfortunate pre-union workarounds).

@tgross35 tgross35 enabled auto-merge April 1, 2025 08:10
And fill semver file for cygwin.
@Berrysoft
Copy link
Contributor Author

Understood, thank you for your explanation.

@tgross35 tgross35 added this pull request to the merge queue Apr 1, 2025
Merged via the queue into rust-lang:main with commit 73672d1 Apr 1, 2025
42 of 43 checks passed
@Berrysoft Berrysoft deleted the cygwin-test branch April 1, 2025 09:29
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Apr 3, 2025
And fill semver file for cygwin.

(backport <rust-lang#4357>)
(cherry picked from commit 5c8804b)
@tgross35 tgross35 mentioned this pull request Apr 3, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants