Skip to content
This repository has been archived by the owner on Feb 5, 2019. It is now read-only.

Commit

Permalink
Add compare_lower and equals_lower methods to StringRef. Switch all u…
Browse files Browse the repository at this point in the history
…sers of

StringsEqualNoCase (from StringExtras.h) to it.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@87020 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
d0k committed Nov 12, 2009
1 parent cf62632 commit 05872ea
Show file tree
Hide file tree
Showing 5 changed files with 35 additions and 8 deletions.
8 changes: 8 additions & 0 deletions include/llvm/ADT/StringRef.h
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,11 @@ namespace llvm {
memcmp(Data, RHS.Data, RHS.Length) == 0);
}

/// equals_lower - Check for string equality, ignoring case.
bool equals_lower(StringRef RHS) const {
return Length == RHS.Length && compare_lower(RHS) == 0;
}

/// compare - Compare two strings; the result is -1, 0, or 1 if this string
/// is lexicographically less than, equal to, or greater than the \arg RHS.
int compare(StringRef RHS) const {
Expand All @@ -110,6 +115,9 @@ namespace llvm {
return Length < RHS.Length ? -1 : 1;
}

/// compare_lower - Compare two strings, ignoring case.
int compare_lower(StringRef RHS) const;

/// str - Get the contents as an std::string.
std::string str() const { return std::string(Data, Length); }

Expand Down
5 changes: 2 additions & 3 deletions lib/CodeGen/SelectionDAG/TargetLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include "llvm/DerivedTypes.h"
#include "llvm/CodeGen/MachineFrameInfo.h"
#include "llvm/CodeGen/SelectionDAG.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/MathExtras.h"
Expand Down Expand Up @@ -2365,7 +2364,7 @@ getRegForInlineAsmConstraint(const std::string &Constraint,
assert(*(Constraint.end()-1) == '}' && "Not a brace enclosed constraint?");

// Remove the braces from around the name.
std::string RegName(Constraint.begin()+1, Constraint.end()-1);
StringRef RegName(Constraint.data()+1, Constraint.size()-2);

// Figure out which register class contains this reg.
const TargetRegisterInfo *RI = TM.getRegisterInfo();
Expand All @@ -2388,7 +2387,7 @@ getRegForInlineAsmConstraint(const std::string &Constraint,

for (TargetRegisterClass::iterator I = RC->begin(), E = RC->end();
I != E; ++I) {
if (StringsEqualNoCase(RegName, RI->getName(*I)))
if (RegName.equals_lower(RI->getName(*I)))
return std::make_pair(*I, RC);
}
}
Expand Down
20 changes: 20 additions & 0 deletions lib/Support/StringRef.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,26 @@ using namespace llvm;
const size_t StringRef::npos;
#endif

static char ascii_tolower(char x) {
if (x >= 'A' && x <= 'Z')
return x - 'A' + 'a';
return x;
}

/// compare_lower - Compare strings, ignoring case.
int StringRef::compare_lower(StringRef RHS) const {
for (size_t I = 0, E = std::min(Length, RHS.Length); I != E; ++I) {
char LHC = ascii_tolower(Data[I]);
char RHC = ascii_tolower(RHS.Data[I]);
if (LHC != RHC)
return LHC < RHC ? -1 : 1;
}

if (Length == RHS.Length)
return 0;
return Length < RHS.Length ? -1 : 1;
}

//===----------------------------------------------------------------------===//
// String Searching
//===----------------------------------------------------------------------===//
Expand Down
4 changes: 2 additions & 2 deletions lib/Target/X86/X86ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -9595,14 +9595,14 @@ X86TargetLowering::getRegForInlineAsmConstraint(const std::string &Constraint,
}

// GCC allows "st(0)" to be called just plain "st".
if (StringsEqualNoCase("{st}", Constraint)) {
if (StringRef("{st}").equals_lower(Constraint)) {
Res.first = X86::ST0;
Res.second = X86::RFP80RegisterClass;
return Res;
}

// flags -> EFLAGS
if (StringsEqualNoCase("{flags}", Constraint)) {
if (StringRef("{flags}").equals_lower(Constraint)) {
Res.first = X86::EFLAGS;
Res.second = X86::CCRRegisterClass;
return Res;
Expand Down
6 changes: 3 additions & 3 deletions tools/bugpoint/ToolRunner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
#include "llvm/Support/Debug.h"
#include "llvm/Support/FileUtilities.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/ADT/StringExtras.h"
#include "llvm/Config/config.h" // for HAVE_LINK_R
#include <fstream>
#include <sstream>
Expand Down Expand Up @@ -610,9 +609,10 @@ IsARMArchitecture(std::vector<std::string> Args)
{
for (std::vector<std::string>::const_iterator
I = Args.begin(), E = Args.end(); I != E; ++I) {
if (!StringsEqualNoCase(*I, "-arch")) {
StringRef S(*I);
if (!S.equals_lower("-arch")) {
++I;
if ((I != E) && !StringsEqualNoCase(I->c_str(), "arm", strlen("arm"))) {
if (I != E && !S.substr(0, strlen("arm")).equals_lower("arm")) {
return true;
}
}
Expand Down

0 comments on commit 05872ea

Please sign in to comment.