resolve: Support imports of associated types and glob imports from traits #138712
+127
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
petrochenkov
commented
Mar 19, 2025
| if path.segments.len() < 2 { | ||
| let guar = self | ||
| .dcx() | ||
| .struct_span_err(span, "cannot infer type, type annotations needed") |
There was a problem hiding this comment.
#138711 is an issue for reporting some proper error here instead of this stub.
fbstj
reviewed
Mar 19, 2025
| if path.segments.len() < 2 { | ||
| let guar = self | ||
| .dcx() | ||
| .struct_span_err(span, "cannot infer type, type annotations needed") |
There was a problem hiding this comment.
Suggested change
| .struct_span_err(span, "cannot infer type, type annotations needed") | |
| .struct_span_err(span, "cannot infer value from uninitialized type") |
from what I can tell of tests/ui/use/import_trait_associated_item_bad.rs the error isn't really type related?
There was a problem hiding this comment.
The error is copypasted from the non-min_generic_const_args case, see #138711.
(It's the Self type that cannot be inferred here.)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #134754, part of #134691.
This PR also fixes an ICE in #138711.
Prohibiting
use Trait::AssocType;at name resolution stage doesn't make sense, the name itself is perfectly resolveable.It's a type checker's problem that the necessary generic args are not passed when the imported
AssocTypeis used, so an error should be reported there.And since we can import associated trait items now, glob imports from traits can also be allowed.