rustc_resolve: Test the order that preludes are resolved #138840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
|
I had trouble with the but i couldn't think of a better test. maybe @petrochenkov has ideas. |
|
... i am a fool. (will fix the tests shortly.) |
jyn514
force-pushed
the
precedence-order
branch
from
0522b05 to
4942d3d
Compare
|
jyn514
force-pushed
the
precedence-order
branch
from
4942d3d to
14238b6
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
precedence-order
branch
from
14238b6 to
bdb144e
Compare
|
ok i have fixed the tests and updated the truth table. the main problem was that i had confused the type namespace and macro namespace, several times, and also had put things in multiple namespaces in a way that confused myself about what was actually being tested. |
jyn514
force-pushed
the
precedence-order
branch
from
bdb144e to
49c3256
Compare
This comment has been minimized.
This comment has been minimized.
jyn514
force-pushed
the
precedence-order
branch
from
49c3256 to
41fdd28
Compare
wesleywiser
approved these changes
Mar 31, 2025
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#138426 (Fix `armv7-sony-vita-newlibeabihf` LLVM target triple) - rust-lang#138840 (rustc_resolve: Test the order that preludes are resolved) - rust-lang#139039 (Reduce kw::Empty usage, part 4) - rust-lang#139151 (tidy: properly check for orphaned unstable_book pages) - rust-lang#139176 (Remove fragile equal-pointers-unequal/*/print3.rs tests.) - rust-lang#139179 (Remove me from vacation) - rust-lang#139181 (Fix invalid link in docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 1, 2025
Rollup merge of rust-lang#138840 - jyn514:precedence-order, r=wesleywiser rustc_resolve: Test the order that preludes are resolved This test is exhaustive. See attached truth table:  Companion PR to rust-lang/reference#1765.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is exhaustive. See attached truth table:
Companion PR to rust-lang/reference#1765.