Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GHA #47

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

JohnTitor
Copy link
Member

On the rust-lang org, we've deprecated the use of Travis CI and migrated to GHA, this PR does it for this repo.
Tested the gh-pages works fine on my fork: https://johntitor.github.io/types-team/
Note that I don't use the scripts on simpleinfra to deploy the gh-pages, as it's outdated and not recommended to use (I remember Pietro said it before, but cannot find the comment on GitHub...)

@nikomatsakis
Copy link
Contributor

r? @rust-lang/infra

@Mark-Simulacrum
Copy link
Member

Hm, did we repurpose a repo or something? Where did the Travis file come from - is there a template that needs adjusting?

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@jackh726
Copy link
Member

jackh726 commented Jun 3, 2022

@Mark-Simulacrum This repo got renamed wg-traits->types-team

@JohnTitor
Copy link
Member Author

JohnTitor commented Jun 3, 2022

Hm, did we repurpose a repo or something? Where did the Travis file come from - is there a template that needs adjusting?

Looking at 2c992ae, the reason would be "we weren't ready to use GHA (or GHA didn't exist) yet".

@jyn514
Copy link
Member

jyn514 commented Jun 3, 2022

Note that I don't use the scripts on simpleinfra to deploy the gh-pages, as it's outdated and not recommended to use (I remember Pietro said it before, but cannot find the comment on GitHub...)

Can we update those scripts to use the code you have here so people can start using them again? That way we don't have to copy-paste these into each repo.

@JohnTitor
Copy link
Member Author

JohnTitor commented Jun 3, 2022

Can we update those scripts to use the code you have here so people can start using them again? That way we don't have to copy-paste these into each repo.

IIRC the reason that it's not recommended is that action is based on Docker (@pietroalbini Am I correct?): https://github.com/rust-lang/simpleinfra/blob/master/github-actions/static-websites/Dockerfile
It's generally slower than JavaScript's (or other forms of actions) so it isn't straightforward, I guess.

@pietroalbini
Copy link
Member

Yeah, the existing Docker action is painfully slow. We should figure out a better solution, but in the meantime the code looks correct!

@JohnTitor
Copy link
Member Author

Could anyone merge this?

@compiler-errors compiler-errors merged commit 4cd3c6a into rust-lang:master Jun 27, 2022
@JohnTitor JohnTitor deleted the stay-cool-travis branch June 27, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants