-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis CI with GHA #47
Conversation
r? @rust-lang/infra |
Hm, did we repurpose a repo or something? Where did the Travis file come from - is there a template that needs adjusting? |
@Mark-Simulacrum This repo got renamed wg-traits->types-team |
Looking at 2c992ae, the reason would be "we weren't ready to use GHA (or GHA didn't exist) yet". |
Co-authored-by: Joshua Nelson <[email protected]>
Can we update those scripts to use the code you have here so people can start using them again? That way we don't have to copy-paste these into each repo. |
IIRC the reason that it's not recommended is that action is based on Docker (@pietroalbini Am I correct?): https://github.com/rust-lang/simpleinfra/blob/master/github-actions/static-websites/Dockerfile |
Yeah, the existing Docker action is painfully slow. We should figure out a better solution, but in the meantime the code looks correct! |
Could anyone merge this? |
On the rust-lang org, we've deprecated the use of Travis CI and migrated to GHA, this PR does it for this repo.
Tested the gh-pages works fine on my fork: https://johntitor.github.io/types-team/
Note that I don't use the scripts on simpleinfra to deploy the gh-pages, as it's outdated and not recommended to use (I remember Pietro said it before, but cannot find the comment on GitHub...)