Merge pull request encode#2587 from jpadilla/select-multiple-disabled

Disable select field if no choices available
rvanlaar · Feb 26, 2015 · 88cd86c · 88cd86c
2 parents 03818ed + bb8690c
commit 88cd86c
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 6 deletions.
diff --git a/rest_framework/templates/rest_framework/horizontal/select_multiple.html b/rest_framework/templates/rest_framework/horizontal/select_multiple.html
@@ -1,11 +1,16 @@
+{% load i18n %}
+{% trans "No items to select." as no_items %}
+
 <div class="form-group">
     {% if field.label %}
         <label class="col-sm-2 control-label {% if style.hide_label %}sr-only{% endif %}">{{ field.label }}</label>
     {% endif %}
     <div class="col-sm-10">
-        <select multiple class="form-control" name="{{ field.name }}">
+        <select multiple {{ field.choices|yesno:",disabled" }} class="form-control" name="{{ field.name }}">
             {% for key, text in field.choices.items %}
-            <option value="{{ key }}" {% if key in field.value %}selected{% endif %}>{{ text }}</option>
+                <option value="{{ key }}" {% if key in field.value %}selected{% endif %}>{{ text }}</option>
+            {% empty %}
+                <option>{{ no_items }}</option>
             {% endfor %}
         </select>
         {% if field.errors %}

diff --git a/rest_framework/templates/rest_framework/inline/select_multiple.html b/rest_framework/templates/rest_framework/inline/select_multiple.html
@@ -1,10 +1,15 @@
+{% load i18n %}
+{% trans "No items to select." as no_items %}
+
 <div class="form-group {% if field.errors %}has-error{% endif %}">
     {% if field.label %}
         <label class="sr-only">{{ field.label }}</label>
     {% endif %}
-    <select multiple class="form-control" name="{{ field.name }}">
+    <select multiple {{ field.choices|yesno:",disabled" }} class="form-control" name="{{ field.name }}">
         {% for key, text in field.choices.items %}
-        <option value="{{ key }}" {% if key in field.value %}selected{% endif %}>{{ text }}</option>
+            <option value="{{ key }}" {% if key in field.value %}selected{% endif %}>{{ text }}</option>
+        {% empty %}
+            <option>{{ no_items }}</option>
         {% endfor %}
     </select>
 </div>
diff --git a/rest_framework/templates/rest_framework/vertical/select_multiple.html b/rest_framework/templates/rest_framework/vertical/select_multiple.html
@@ -1,10 +1,15 @@
+{% load i18n %}
+{% trans "No items to select." as no_items %}
+
 <div class="form-group {% if field.errors %}has-error{% endif %}">
     {% if field.label %}
         <label {% if style.hide_label %}class="sr-only"{% endif %}>{{ field.label }}</label>
     {% endif %}
-    <select multiple class="form-control" name="{{ field.name }}">
+    <select multiple {{ field.choices|yesno:",disabled" }} class="form-control" name="{{ field.name }}">
         {% for key, text in field.choices.items %}
-        <option value="{{ key }}" {% if key in field.value %}selected{% endif %}>{{ text }}</option>
+            <option value="{{ key }}" {% if key in field.value %}selected{% endif %}>{{ text }}</option>
+        {% empty %}
+            <option>{{ no_items }}</option>
         {% endfor %}
     </select>
     {% if field.errors %}