MDL-11448 FirstClass Authentication does not hold settings and has co…

…smetic and info leakage issues, patch by Dan Trockman
rvtraveller · Oct 7, 2007 · e5245c7 · e5245c7
1 parent 1bc8aab
commit e5245c7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/auth/fc/auth.php b/auth/fc/auth.php
@@ -88,7 +88,7 @@ function get_userinfo($username) {
 
         $userinfo = array();
 
-        $fpp = new fcFPP($this->config->host, $this->config->port);
+        $fpp = new fcFPP($this->config->host, $this->config->fppport);
         if ($fpp->open()) {
             if ($fpp->login($this->config->userid, $this->config->passwd)) {
                 $userinfo['firstname']   = $fpp->getUserInfo($username,"1202");
@@ -121,7 +121,7 @@ function iscreator($username) {
 
         $fcgroups = array();
 
-        $fpp = new fcFPP($this->config->host, $this->config->port);
+        $fpp = new fcFPP($this->config->host, $this->config->fppport);
         if ($fpp->open()) {
             if ($fpp->login($this->config->userid, $this->config->passwd)) {
                 $fcgroups = $fpp->getGroups($username);
@@ -224,7 +224,7 @@ function process_config($config) {
         }
 
         // save settings
-        set_config('host',      $config->user,     'auth/fc');
+        set_config('host',      $config->host,     'auth/fc');
         set_config('fppport',   $config->fppport,  'auth/fc');
         set_config('userid',    $config->userid,   'auth/fc');
         set_config('passwd',    $config->passwd,   'auth/fc');

diff --git a/auth/fc/fcFPP.php b/auth/fc/fcFPP.php
@@ -50,7 +50,7 @@ function open()
     $conn = fsockopen($host, $port, $errno, $errstr, 5);
     if (!$conn)
     {
-        print_error('auth_fcconnfail','auth', array($errno, $errstr));
+        print_error('auth_fcconnfail','auth', '', array($errno, $errstr));
         return false;
     }
 

diff --git a/lang/en_utf8/auth.php b/lang/en_utf8/auth.php
@@ -123,7 +123,7 @@
 $string['auth_fcpasswd'] = 'Password for the account above.';
 $string['auth_fctitle'] = 'FirstClass server';
 $string['auth_fcuserid'] = 'Userid for FirstClass account with privilege \'Subadministrator\' set.';
-$string['auth_fchost_key'] = 'Host:';
+$string['auth_fchost_key'] = 'Host';
 $string['auth_fcfppport_key'] = 'Port';
 $string['auth_fcuserid_key'] = 'User ID';
 $string['auth_fcpasswd_key'] = 'Password';