WebAuthnAuthenticationFilterTests asserts platform

rwinch · Oct 16, 2024 · 151a26b · 151a26b
1 parent e312b39
commit 151a26b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/...ringframework/security/web/webauthn/authentication/WebAuthnAuthenticationFilterTests.java b/...ringframework/security/web/webauthn/authentication/WebAuthnAuthenticationFilterTests.java
@@ -30,10 +30,11 @@
 import org.springframework.mock.web.MockHttpServletResponse;
 import org.springframework.mock.web.MockServletContext;
 import org.springframework.security.authentication.AuthenticationManager;
-import org.springframework.security.webauthn.api.TestPublicKeyCredentialRequestOptions;
 import org.springframework.security.webauthn.api.AuthenticatorAssertionResponse;
-import org.springframework.security.webauthn.api.PublicKeyCredentialRequestOptions;
+import org.springframework.security.webauthn.api.AuthenticatorAttachment;
 import org.springframework.security.webauthn.api.PublicKeyCredential;
+import org.springframework.security.webauthn.api.PublicKeyCredentialRequestOptions;
+import org.springframework.security.webauthn.api.TestPublicKeyCredentialRequestOptions;
 import org.springframework.security.webauthn.authentication.WebAuthnAuthenticationRequestToken;
 import org.springframework.security.webauthn.management.RelyingPartyAuthenticationRequest;
 import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
@@ -165,7 +166,7 @@ void doFilterWhenValidThenOk() throws Exception {
 		assertThat(assertionResponse.getUserHandle().toBase64UrlString()).isEqualTo("Q3_0Xd64_HW0BlKRAJnVagJTpLKLgARCj8zjugpRnVo");
 		assertThat(publicKey.getClientExtensionResults().getOutputs()).isEmpty();
 		assertThat(authnRequest.getRequestOptions()).isEqualTo(options);
-		// FIXME: assert authenticatorAttachment: platform but does not exist on publicKey
+		assertThat(authnRequest.getPublicKey().getAuthenticatorAttachment()).isEqualTo(AuthenticatorAttachment.PLATFORM);
 	}
 
 	private static MockHttpServletRequest matchingRequest(String body) {