Fix MD_S8ChopWhitespace underflow and infinite loop #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MD_S8ChopWhitespace` has two obvious bugs. 1) `MD_u64 i = string.size-1` can underflow when string.size is 0. 2) `i < string.size` is the wrong condition to check for a loop that starts at the end of the string. I "fixed" the loop in this PR, but haven't tested this code at all, so you may want to test it on your side or just fix the loop yourself in whatever way you see fit. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MD_S8ChopWhitespacehas two obvious bugs:MD_u64 i = string.size-1can underflow when string.size is 0.i < string.sizeis the wrong condition to check for a loop that starts at the end of the string.Theoretically, this PR fixes both issues, but haven't tested this code at all, so you may want to test it on your side or just fix the loop yourself in whatever way you see fit. :)
The code I wrote is a bit contrived, but I looped forward instead of backward to avoid the decrement at zero problem that would've required us to replace MD_u64 with a signed type. This preserves the upper half of the unsigned range in the extraordinarly unlikely case that someone has a string that large (maybe's it's a virtual string? lol).