fix(test): do NOT quote argument values for mocked invocations (stars…

…hip#1527) Co-authored-by: Thomas O'Donnell <[email protected]>
ryanpcmcquen · Aug 24, 2020 · faba2d1 · faba2d1
1 parent 46a51d7
commit faba2d1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/modules/erlang.rs b/src/modules/erlang.rs
@@ -57,10 +57,10 @@ fn get_erlang_version() -> Option<String> {
         &[
             "-noshell",
             "-eval",
-            "'Fn=filename:join([code:root_dir(),\"releases\",erlang:system_info(otp_release),\"OTP_VERSION\"]),\
+            "Fn=filename:join([code:root_dir(),\"releases\",erlang:system_info(otp_release),\"OTP_VERSION\"]),\
              {ok,Content}=file:read_file(Fn),\
              io:format(\"~s\",[Content]),\
-             halt(0).'"
+             halt(0)."
         ]
     )?.stdout.trim().to_string())
 }

diff --git a/src/modules/php.rs b/src/modules/php.rs
@@ -24,7 +24,7 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
         "php",
         &[
             "-nr",
-            "'echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;'",
+            "echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;",
         ],
     ) {
         Some(php_cmd_output) => {

diff --git a/src/utils.rs b/src/utils.rs
@@ -115,7 +115,7 @@ active boot switches: -d:release\n",
             stdout: String::from("5.26.1"),
             stderr: String::default(),
         }),
-        "php -nr 'echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;'" => {
+        "php -nr echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;" => {
             Some(CommandOutput {
                 stdout: String::from("7.3.8"),
                 stderr: String::default(),
-Original file line number
+Diff line change
@@ Expand Up @@
             "php",
             &[
                 "-nr",
-                "'echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;'",
+                "echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;",
             ],
         ) {
             Some(php_cmd_output) => {
@@ Expand Down @@