🤖 Merge PR DefinitelyTyped#64247 fix(simple-oauth2): correct type for…

… 'scope' field in PasswordTokenConfig by @pafik13
ryletko · Feb 7, 2023 · f887693 · f887693
1 parent f216e27
commit f887693
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/types/simple-oauth2/index.d.ts b/types/simple-oauth2/index.d.ts
@@ -281,7 +281,7 @@ export interface PasswordTokenConfig {
     /** A string that represents the registered password. */
     password: string;
     /** A string or array of strings that represents the application privileges */
-    scope: string | string[];
+    scope?: string | string[];
 
     /**
      * Additional options will be automatically serialized as params for the token request.

diff --git a/types/simple-oauth2/simple-oauth2-tests.ts b/types/simple-oauth2/simple-oauth2-tests.ts
@@ -73,15 +73,29 @@ const oauth2ResourceOwnerPassword = new oauth2lib.ResourceOwnerPassword(
 
 // #Password Credentials Flow
 (async () => {
-    const tokenConfig = {
+    const tokenConfig1 = {
+        username: "username",
+        password: "password",
+    };
+
+    const tokenConfig2 = {
         username: "username",
         password: "password",
         scope: ["<scope1>", "<scope2>"],
     };
 
+    const tokenConfig3 = {
+        username: "username",
+        password: "password",
+        scope: "<scope1>",
+    };
+
     // Save the access token
     try {
-        const result = await oauth2ResourceOwnerPassword.getToken(tokenConfig);
+        let result = await oauth2ResourceOwnerPassword.getToken(tokenConfig1);
+        result = await oauth2ResourceOwnerPassword.getToken(tokenConfig2);
+        result = await oauth2ResourceOwnerPassword.getToken(tokenConfig3);
+
         const accessToken = oauth2ResourceOwnerPassword.createToken(result.token);
     } catch (error) {
         console.log("Access Token Error", error.message);