Skip to content

Commit

Permalink
ofproto-dpif: Mark rule_release() as no_thread_safety_analysis.
Browse files Browse the repository at this point in the history
Otherwise new Clang complains about this function because it only sometimes
releases the lock (that is, it only does it when there is a lock to
release).

I first noticed these warnings with Clang 1:3.4~svn188890-1~exp1.
I previously used version 1:3.4~svn187484-1~exp1.

Signed-off-by: Ben Pfaff <[email protected]>
  • Loading branch information
blp committed Aug 22, 2013
1 parent da20356 commit c1f1f65
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ofproto/ofproto-dpif.c
Original file line number Diff line number Diff line change
Expand Up @@ -4849,6 +4849,7 @@ choose_miss_rule(enum ofputil_port_config config, struct rule_dpif *miss_rule,

void
rule_release(struct rule_dpif *rule)
OVS_NO_THREAD_SAFETY_ANALYSIS
{
if (rule) {
ovs_rwlock_unlock(&rule->up.evict);
Expand Down

0 comments on commit c1f1f65

Please sign in to comment.