Skip to content

Commit

Permalink
chart/base inherits from component/base
Browse files Browse the repository at this point in the history
  • Loading branch information
pissang committed Dec 24, 2014
1 parent 86341c5 commit ab94664
Show file tree
Hide file tree
Showing 14 changed files with 25 additions and 70 deletions.
6 changes: 1 addition & 5 deletions src/chart/bar.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -29,10 +28,8 @@ define(function (require) {
* @param {Object} component 组件
*/
function Bar(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this.refresh(option);
}
Expand Down Expand Up @@ -878,7 +875,6 @@ define(function (require) {
};

zrUtil.inherits(Bar, ChartBase);
zrUtil.inherits(Bar, ComponentBase);

// 图表注册
require('../chart').define('bar', Bar);
Expand Down
9 changes: 8 additions & 1 deletion src/chart/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,15 @@ define(function (require) {
var ecAnimation = require('../util/ecAnimation');
var ecEffect = require('../util/ecEffect');
var accMath = require('../util/accMath');
var ComponentBase = require('../component/Base');

var zrUtil = require('zrender/tool/util');
var zrArea = require('zrender/tool/area');

function Base(){
function Base(ecTheme, messageCenter, zr, option, myChart) {

ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);

var self = this;
this.selectedMap = {};
this.lastShapeList = [];
Expand Down Expand Up @@ -1595,5 +1600,7 @@ define(function (require) {
}
};

zrUtil.inherits(Base, ComponentBase);

return Base;
});
6 changes: 1 addition & 5 deletions src/chart/chord.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
define(function (require) {
'use strict';

var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -28,10 +27,8 @@ define(function (require) {
var ChordLayout = require('../layout/Chord');

function Chord(ecTheme, messageCenter, zr, option, myChart) {
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this.scaleLineLength = 4;

Expand Down Expand Up @@ -985,7 +982,6 @@ define(function (require) {
};

zrUtil.inherits(Chord, ChartBase);
zrUtil.inherits(Chord, ComponentBase);

// 图表注册
require('../chart').define('chord', Chord);
Expand Down
8 changes: 2 additions & 6 deletions src/chart/eventRiver.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

var eventRiverLayout = require('../layout/eventRiver');
Expand All @@ -33,10 +32,8 @@ define(function (require) {
* @param {Object} component 组件
*/
function EventRiver(ecTheme, messageCenter, zr, option, myChart) {
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
// 图表基类
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

var self = this;
self._ondragend = function () {
Expand Down Expand Up @@ -270,7 +267,6 @@ define(function (require) {
};

zrUtil.inherits(EventRiver, ChartBase);
zrUtil.inherits(EventRiver, ComponentBase);

// 图表注册
require('../chart').define('eventRiver', EventRiver);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/force.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
define(function (require) {
'use strict';

var ComponentBase = require('../component/base');
var ChartBase = require('./base');

var Graph = require('../data/Graph');
Expand All @@ -35,10 +34,8 @@ define(function (require) {
*/
function Force(ecTheme, messageCenter, zr, option, myChart) {
var self = this;
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

// 保存节点的位置,改变数据时能够有更好的动画效果
this.__nodePositionMap = {};
Expand Down Expand Up @@ -844,7 +841,6 @@ define(function (require) {
}

zrUtil.inherits(Force, ChartBase);
zrUtil.inherits(Force, ComponentBase);

// 图表注册
require('../chart').define('force', Force);
Expand Down
8 changes: 2 additions & 6 deletions src/chart/funnel.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -28,11 +27,9 @@ define(function (require) {
* @param {Object} series 数据
* @param {Object} component 组件
*/
function Funnel(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
function Funnel(ecTheme, messageCenter, zr, option, myChart) {
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);
this.refresh(option);
}

Expand Down Expand Up @@ -731,7 +728,6 @@ define(function (require) {
};

zrUtil.inherits(Funnel, ChartBase);
zrUtil.inherits(Funnel, ComponentBase);

// 图表注册
require('../chart').define('funnel', Funnel);
Expand Down
8 changes: 2 additions & 6 deletions src/chart/gauge.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -29,11 +28,9 @@ define(function (require) {
* @param {Object} series 数据
* @param {Object} component 组件
*/
function Gauge(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
function Gauge(ecTheme, messageCenter, zr, option, myChart) {
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);
this.refresh(option);
}

Expand Down Expand Up @@ -548,7 +545,6 @@ define(function (require) {
};

zrUtil.inherits(Gauge, ChartBase);
zrUtil.inherits(Gauge, ComponentBase);

// 图表注册
require('../chart').define('gauge', Gauge);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/island.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -24,10 +23,8 @@ define(function (require) {
* @param {Object} option 图表选项
*/
function Island(ecTheme, messageCenter, zr, option, myChart) {
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, {}, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this._nameConnector;
this._valueConnector;
Expand Down Expand Up @@ -241,7 +238,6 @@ define(function (require) {
};

zrUtil.inherits(Island, ChartBase);
zrUtil.inherits(Island, ComponentBase);

// 图表注册
require('../chart').define('island', Island);
Expand Down
8 changes: 2 additions & 6 deletions src/chart/k.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -27,11 +26,9 @@ define(function (require) {
* @param {Object} series 数据
* @param {Object} component 组件
*/
function K(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
function K(ecTheme, messageCenter, zr, option, myChart) {
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this.refresh(option);
}
Expand Down Expand Up @@ -489,7 +486,6 @@ define(function (require) {
};

zrUtil.inherits(K, ChartBase);
zrUtil.inherits(K, ComponentBase);

// 图表注册
require('../chart').define('k', K);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/line.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -31,10 +30,8 @@ define(function (require) {
* @param {Object} component 组件
*/
function Line(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this.refresh(option);
}
Expand Down Expand Up @@ -929,7 +926,6 @@ define(function (require) {
IconShape.prototype.iconLibrary['legendLineIcon'] = legendLineIcon;

zrUtil.inherits(Line, ChartBase);
zrUtil.inherits(Line, ComponentBase);

// 图表注册
require('../chart').define('line', Line);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/map.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand Down Expand Up @@ -39,10 +38,8 @@ define(function (require) {
* @param {Object} component 组件
*/
function Map(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

var self = this;
self._onmousewheel = function(params) {
Expand Down Expand Up @@ -1528,7 +1525,6 @@ define(function (require) {
};

zrUtil.inherits(Map, ChartBase);
zrUtil.inherits(Map, ComponentBase);

// 图表注册
require('../chart').define('map', Map);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/pie.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -30,10 +29,8 @@ define(function (require) {
* @param {Object} component 组件
*/
function Pie(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

var self = this;
/**
Expand Down Expand Up @@ -1050,7 +1047,6 @@ define(function (require) {
};

zrUtil.inherits(Pie, ChartBase);
zrUtil.inherits(Pie, ComponentBase);

// 图表注册
require('../chart').define('pie', Pie);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/radar.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*/

define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -29,10 +28,8 @@
* @exports Radar
*/
function Radar(ecTheme, messageCenter, zr, option, myChart) {
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this.refresh(option);
}
Expand Down Expand Up @@ -424,7 +421,6 @@
};

zrUtil.inherits(Radar, ChartBase);
zrUtil.inherits(Radar, ComponentBase);

// 图表注册
require('../chart').define('radar', Radar);
Expand Down
6 changes: 1 addition & 5 deletions src/chart/scatter.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
*
*/
define(function (require) {
var ComponentBase = require('../component/base');
var ChartBase = require('./base');

// 图形依赖
Expand All @@ -29,10 +28,8 @@ define(function (require) {
* @param {Object} component 组件
*/
function Scatter(ecTheme, messageCenter, zr, option, myChart){
// 基类
ComponentBase.call(this, ecTheme, messageCenter, zr, option, myChart);
// 图表基类
ChartBase.call(this);
ChartBase.call(this, ecTheme, messageCenter, zr, option, myChart);

this.refresh(option);
}
Expand Down Expand Up @@ -434,7 +431,6 @@ define(function (require) {
};

zrUtil.inherits(Scatter, ChartBase);
zrUtil.inherits(Scatter, ComponentBase);

// 图表注册
require('../chart').define('scatter', Scatter);
Expand Down

0 comments on commit ab94664

Please sign in to comment.