Reject negative cost components

No work has negative cost. Previously such negative costs could go unnoticed, or noticed only if explain plan is produced.
rznag · Dec 15, 2023 · ab27cb8 · ab27cb8
1 parent 7e8ad5a
commit ab27cb8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/cost/LocalCostEstimate.java b/core/trino-main/src/main/java/io/trino/cost/LocalCostEstimate.java
@@ -21,7 +21,9 @@
 import java.util.stream.Stream;
 
 import static com.google.common.base.MoreObjects.toStringHelper;
+import static com.google.common.base.Preconditions.checkArgument;
 import static java.lang.Double.NaN;
+import static java.lang.Double.isNaN;
 
 /**
  * Represents inherent cost of some plan node, not including cost of its sources.
@@ -63,6 +65,9 @@ public LocalCostEstimate(
             @JsonProperty("maxMemory") double maxMemory,
             @JsonProperty("networkCost") double networkCost)
     {
+        checkArgument(isNaN(cpuCost) || cpuCost >= 0, "cpuCost cannot be negative: %s", cpuCost);
+        checkArgument(isNaN(maxMemory) || maxMemory >= 0, "maxMemory cannot be negative: %s", maxMemory);
+        checkArgument(isNaN(networkCost) || networkCost >= 0, "networkCost cannot be negative: %s", networkCost);
         this.cpuCost = cpuCost;
         this.maxMemory = maxMemory;
         this.networkCost = networkCost;

diff --git a/core/trino-main/src/main/java/io/trino/cost/PlanNodeStatsAndCostSummary.java b/core/trino-main/src/main/java/io/trino/cost/PlanNodeStatsAndCostSummary.java
@@ -16,6 +16,9 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.lang.Double.isNaN;
+
 public class PlanNodeStatsAndCostSummary
 {
     private final double outputRowCount;
@@ -32,6 +35,11 @@ public PlanNodeStatsAndCostSummary(
             @JsonProperty("memoryCost") double memoryCost,
             @JsonProperty("networkCost") double networkCost)
     {
+        checkArgument(isNaN(outputRowCount) || outputRowCount >= 0, "outputRowCount cannot be negative: %s", outputRowCount);
+        checkArgument(isNaN(outputSizeInBytes) || outputSizeInBytes >= 0, "outputSizeInBytes cannot be negative: %s", outputSizeInBytes);
+        checkArgument(isNaN(cpuCost) || cpuCost >= 0, "cpuCost cannot be negative: %s", cpuCost);
+        checkArgument(isNaN(memoryCost) || memoryCost >= 0, "memoryCost cannot be negative: %s", memoryCost);
+        checkArgument(isNaN(networkCost) || networkCost >= 0, "networkCost cannot be negative: %s", networkCost);
         this.outputRowCount = outputRowCount;
         this.outputSizeInBytes = outputSizeInBytes;
         this.cpuCost = cpuCost;