Skip to content

Commit

Permalink
Automated rollback of commit 3edf41b.
Browse files Browse the repository at this point in the history
*** Reason for rollback ***

Rollback was requested by original authors @hmemcpy and @ittaiz in bazelbuild#3201:

"We found a problem with this patch... seems that tests that are added dynamically by the test runner (in our case, specs2 'examples' that are generated with Fragments.foreach) do not appear in the xml!"

This should be part of 0.12.0-rc1, otherwise that release will have the above mentioned regression.

*** Original change description ***

Skipping writing FILTERED tests to test.xml

This fixes bazelbuild#3201 by preventing tests that haven't actually run to be written to the test.xml. This is consistent with how e.g. surefire reports work, tests that were filtered out do not appear in the xml.
This allows changing the Bazel plugin in such a way that does not depend on `time` being 0.0.

Closes bazelbuild#4596.

PiperOrigin-RevId: 188455315
  • Loading branch information
philwo authored and Copybara-Service committed Mar 9, 2018
1 parent b961b0a commit 2ee6dd2
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 94 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,6 @@ private void writeTestSuiteProperties(XmlWriter writer, TestResult result) throw
private void writeTestCases(XmlWriter writer, TestResult result,
Iterable<Throwable> parentFailures) throws IOException {
for (TestResult child : result.getChildResults()) {
if (child.getStatus() == TestResult.Status.FILTERED) {
continue;
}
if (child.getChildResults().isEmpty()) {
writeTestCase(writer, child, parentFailures);
}
Expand Down

This file was deleted.

0 comments on commit 2ee6dd2

Please sign in to comment.