fixing lints

.eslintrc

@@ -38,6 +38,7 @@
     "no-continue": ["off"],
     "default-case": ["off"],
     "object-curly-spacing": ["error", "never"],
-    "node/process-exit-as-throw": ["off"]
+    "node/process-exit-as-throw": ["off"],
+    "prefer-object-spread": ["off"]
   }
 }

lib/doc/cell.js

@@ -1,5 +1,4 @@
-'use strict';
-
+/* eslint-disable max-classes-per-file */
 const colCache = require('../utils/col-cache');
 const _ = require('../utils/under-dash');
 const Enums = require('./enums');
@@ -580,35 +579,29 @@ class DateValue {
 
 class HyperlinkValue {
   constructor(cell, value) {
-    this.model = Object.assign(
-      {
-        address: cell.address,
-        type: Cell.Types.Hyperlink,
-        text: value ? value.text : undefined,
-        hyperlink: value ? value.hyperlink : undefined,
-      },
-      value && value.tooltip ? {tooltip: value.tooltip} : {}
-    );
+    this.model = {
+      address: cell.address,
+      type: Cell.Types.Hyperlink,
+      text: value ? value.text : undefined,
+      hyperlink: value ? value.hyperlink : undefined,
+      tooltip: value.tooltip,
+    };
   }
 
   get value() {
-    return Object.assign(
-      {
-        text: this.model.text,
-        hyperlink: this.model.hyperlink,
-      },
-      this.model.tooltip ? {tooltip: this.model.tooltip} : {}
-    );
+    return {
+      text: this.model.text,
+      hyperlink: this.model.hyperlink,
+      tooltip: this.model.tooltip,
+    };
   }
 
   set value(value) {
-    this.model = Object.assign(
-      {
-        text: value.text,
-        hyperlink: value.hyperlink,
-      },
-      value && value.tooltip ? {tooltip: value.tooltip} : {}
-    );
+    this.model = {
+      text: value.text,
+      hyperlink: value.hyperlink,
+      tooltip: value.tooltip,
+    };
   }
 
   get text() {

lib/doc/table.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 const colCache = require('./../utils/col-cache');
 
 class Column {

lib/doc/workbook.js

@@ -47,6 +47,7 @@ class Workbook {
     const id = this.nextId;
 
     if (name && (name.length > 31)) {
+      // eslint-disable-next-line no-console
       console.warn(`Worksheet name ${name} exceeds 31 chars. This will be truncated`);
     }
     name = (name || `sheet${id}`).substring(0, 31);

lib/exceljs.browser.js

@@ -1,3 +1,4 @@
+/* eslint-disable import/no-extraneous-dependencies,node/no-unpublished-require */
 require('core-js/modules/es.promise');
 require('core-js/modules/es.object.assign');
 require('core-js/modules/es.object.keys');

lib/stream/xlsx/sheet-rels-writer.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 const utils = require('../../utils/utils');
 const RelType = require('../../xlsx/rel-type');
 

lib/utils/col-cache.js

@@ -188,7 +188,7 @@ const colCache = {
     }
 
     const address = this.decodeAddress(reference);
-    return sheetName ? Object.assign({sheetName}, address) : address;
+    return sheetName ? {sheetName, ...address} : address;
   },
 
   // convert row,col into address string

lib/utils/flow-control.js

@@ -200,7 +200,10 @@ class FlowControl extends EventEmitter {
 
   createChild() {
     // Create a down-stream flow-control
-    const options = Object.assign({parent: this}, this.options);
+    const options = {
+      parent: this,
+      ...this.options,
+    };
     const child = new FlowControl(options);
     this.children.push(child);
 

lib/utils/stream-buf.js

@@ -1,5 +1,4 @@
-'use strict';
-
+/* eslint-disable max-classes-per-file */
 const Stream = require('stream');
 
 const utils = require('./utils');

lib/utils/utils.js

@@ -126,8 +126,8 @@ const utils = {
   fs: {
     exists(path) {
       return new Promise(resolve => {
-        fs.exists(path, exists => {
-          resolve(exists);
+        fs.access(path, fs.constants.F_OK, err => {
+          resolve(!err);
         });
       });
     },

lib/utils/zip-stream.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 const events = require('events');
 const JSZip = require('jszip');
 

lib/xlsx/xform/sheet/cell-xform.js

@@ -80,15 +80,11 @@ class CellXform extends BaseXform {
         if (options.sharedStrings && model.text !== undefined && model.text !== null) {
           model.ssId = options.sharedStrings.add(model.text);
         }
-        options.hyperlinks.push(
-          Object.assign(
-            {
-              address: model.address,
-              target: model.hyperlink,
-            },
-            model.tooltip ? {tooltip: model.tooltip} : {}
-          )
-        );
+        options.hyperlinks.push({
+          address: model.address,
+          target: model.hyperlink,
+          tooltip: model.tooltip,
+        });
         break;
 
       case Enums.ValueType.Merge:

lib/xlsx/xform/sheet/hyperlink-xform.js

@@ -6,27 +6,20 @@ class HyperlinkXform extends BaseXform {
   }
 
   render(xmlStream, model) {
-    xmlStream.leafNode(
-      'hyperlink',
-      Object.assign(
-        {
-          ref: model.address,
-          'r:id': model.rId,
-        },
-        model.tooltip ? {tooltip: model.tooltip} : {}
-      )
-    );
+    xmlStream.leafNode('hyperlink', {
+      ref: model.address,
+      'r:id': model.rId,
+      tooltip: model.tooltip,
+    });
   }
 
   parseOpen(node) {
     if (node.name === 'hyperlink') {
-      this.model = Object.assign(
-        {
-          address: node.attributes.ref,
-          rId: node.attributes['r:id'],
-        },
-        node.attributes.tooltip ? {tooltip: node.attributes.tooltip} : {}
-      );
+      this.model = {
+        address: node.attributes.ref,
+        rId: node.attributes['r:id'],
+        tooltip: node.attributes.tooltip,
+      };
       return true;
     }
     return false;

lib/xlsx/xform/style/border-xform.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 const BaseXform = require('../base-xform');
 
 const ColorXform = require('./color-xform');
@@ -133,7 +134,10 @@ class BorderXform extends BaseXform {
     function add(edgeModel, edgeXform) {
       if (edgeModel && !edgeModel.color && model.color) {
         // don't mess with incoming models
-        edgeModel = Object.assign({}, edgeModel, {color: model.color});
+        edgeModel = {
+          ...edgeModel,
+          color: model.color,
+        };
       }
       edgeXform.render(xmlStream, edgeModel, color);
     }

lib/xlsx/xform/style/fill-xform.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 const BaseXform = require('../base-xform');
 
 const ColorXform = require('./color-xform');

lib/xlsx/xform/style/styles-xform.js

@@ -1,3 +1,4 @@
+/* eslint-disable max-classes-per-file */
 const Enums = require('../../../doc/enums');
 const XmlStream = require('../../../utils/xml-stream');
 

lib/xlsx/xlsx.js

@@ -634,16 +634,18 @@ class XLSX {
   writeFile(filename, options) {
     const stream = fs.createWriteStream(filename);
 
-    return new Promise(async (resolve, reject) => {
+    return new Promise((resolve, reject) => {
       stream.on('finish', () => {
         resolve();
       });
       stream.on('error', error => {
         reject(error);
       });
 
-      await this.write(stream, options);
-      stream.end();
+      this.write(stream, options)
+        .then(() => {
+          stream.end();
+        });
     });
   }
 

package.json

@@ -13,7 +13,7 @@
     "url": "https://github.com/exceljs/exceljs.git"
   },
   "engines": {
-    "node": ">=8.0.0"
+    "node": ">=8.3.0"
   },
   "main": "./lib/exceljs.nodejs.js",
   "browser": "./dist/exceljs.min.js",

spec/.eslintrc

@@ -7,6 +7,7 @@
     "array-bracket-spacing": ["off"],
     "no-sparse-arrays": ["off"],
     "object-property-newline": ["off"],
+    "prefer-object-spread": ["off"],
     "no-underscore-dangle": ["off"]
   },
   "globals": {

spec/unit/xlsx/xform/drawing/data/drawing.1.0.js

@@ -2,8 +2,8 @@ module.exports = {
   anchors: [
     {
       range: {
-        tl: { nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0 },
-        br: { nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0 },
+        tl: {nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0},
+        br: {nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0},
       },
       picture: {
         rId: 'rId1',
@@ -17,7 +17,7 @@ module.exports = {
           nativeCol: 5,
           nativeColOff: 320000,
         },
-        ext: { width: 100, height: 200 },
+        ext: {width: 100, height: 200},
       },
       picture: {
         rId: 'rId2',

spec/unit/xlsx/xform/drawing/data/drawing.1.1.js

@@ -3,8 +3,8 @@ module.exports = {
     {
       anchorType: 'xdr:twoCellAnchor',
       range: {
-        tl: { nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0 },
-        br: { nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0 },
+        tl: {nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0},
+        br: {nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0},
       },
       picture: {
         index: 1,
@@ -20,7 +20,7 @@ module.exports = {
           nativeCol: 5,
           nativeColOff: 320000,
         },
-        ext: { width: 100, height: 200 },
+        ext: {width: 100, height: 200},
       },
       picture: {
         index: 2,

spec/unit/xlsx/xform/drawing/data/drawing.1.3.js

@@ -2,8 +2,8 @@ module.exports = {
   anchors: [
     {
       range: {
-        tl: { nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0 },
-        br: { nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0 },
+        tl: {nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0},
+        br: {nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0},
         editAs: 'oneCell',
       },
       picture: {
@@ -18,7 +18,7 @@ module.exports = {
           nativeCol: 5,
           nativeColOff: 320000,
         },
-        ext: { width: 100, height: 200 },
+        ext: {width: 100, height: 200},
         editAs: 'oneCell',
       },
       picture: {

spec/unit/xlsx/xform/drawing/data/drawing.1.4.js

@@ -2,8 +2,8 @@ module.exports = {
   anchors: [
     {
       range: {
-        tl: { nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0 },
-        br: { nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0 },
+        tl: {nativeRow: 0, nativeRowOff: 0, nativeCol: 0, nativeColOff: 0},
+        br: {nativeRow: 7, nativeRowOff: 0, nativeCol: 3, nativeColOff: 0},
         editAs: 'oneCell',
       },
       picture: {
@@ -18,7 +18,7 @@ module.exports = {
           nativeCol: 5,
           nativeColOff: 320000,
         },
-        ext: { width: 100, height: 200 },
+        ext: {width: 100, height: 200},
         editAs: 'oneCell',
       },
       picture: {

test/.eslintrc

@@ -3,6 +3,8 @@
   "rules": {
     "no-new": ["off"],
     "max-len": ["off"],
-    "no-console": ["off"]
+    "no-console": ["off"],
+    "no-underscore-dangle": ["off"],
+    "spaced-comment": ["off"]
   }
 }