Skip to content

Commit

Permalink
Excises xvid from libhb because it's not worthy. Having two different…
Browse files Browse the repository at this point in the history
… MPEG-4 Part 2 encoders is superfluous and when choosing between ffmpeg and xvid, xvid is the clear loser since we need to keep ffmpeg around for other functions and xvid constantly requires attention to ensure it compiles.

MacGui: Removes some stray references to the codec and unlinks it from the Xcode project.
CLI: Removes references to the codec and removes it as a dependency.

git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@2448 b64f7644-9d1e-0410-96f1-a4d463321fa5
  • Loading branch information
jbrjake committed May 26, 2009
1 parent fdadd57 commit 4106a36
Show file tree
Hide file tree
Showing 19 changed files with 9 additions and 391 deletions.
12 changes: 0 additions & 12 deletions contrib/xvidcore/A00-libtool.patch

This file was deleted.

31 changes: 0 additions & 31 deletions contrib/xvidcore/P00-darwin.patch

This file was deleted.

17 changes: 0 additions & 17 deletions contrib/xvidcore/P01-cygwin.patch

This file was deleted.

28 changes: 0 additions & 28 deletions contrib/xvidcore/module.defs

This file was deleted.

2 changes: 0 additions & 2 deletions contrib/xvidcore/module.rules

This file was deleted.

6 changes: 2 additions & 4 deletions libhb/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,8 @@ struct hb_job_s
areBframes: boolean to note if b-frames are included in x264opts */
#define HB_VCODEC_MASK 0x0000FF
#define HB_VCODEC_FFMPEG 0x000001
#define HB_VCODEC_XVID 0x000002
#define HB_VCODEC_X264 0x000004
#define HB_VCODEC_THEORA 0x000008
#define HB_VCODEC_X264 0x000002
#define HB_VCODEC_THEORA 0x000004

int vcodec;
float vquality;
Expand Down Expand Up @@ -663,7 +662,6 @@ extern hb_work_object_t hb_encvobsub;
extern hb_work_object_t hb_deccc608;
extern hb_work_object_t hb_render;
extern hb_work_object_t hb_encavcodec;
extern hb_work_object_t hb_encxvid;
extern hb_work_object_t hb_encx264;
extern hb_work_object_t hb_enctheora;
extern hb_work_object_t hb_deca52;
Expand Down
242 changes: 0 additions & 242 deletions libhb/encxvid.c

This file was deleted.

2 changes: 0 additions & 2 deletions libhb/hb.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ hb_handle_t * hb_init( int verbose, int update_check )
hb_register( &hb_deccc608 );
hb_register( &hb_render );
hb_register( &hb_encavcodec );
hb_register( &hb_encxvid );
hb_register( &hb_encx264 );
hb_register( &hb_enctheora );
hb_register( &hb_deca52 );
Expand Down Expand Up @@ -254,7 +253,6 @@ hb_handle_t * hb_init_dl( int verbose, int update_check )
hb_register( &hb_deccc608 );
hb_register( &hb_render );
hb_register( &hb_encavcodec );
hb_register( &hb_encxvid );
hb_register( &hb_encx264 );
hb_register( &hb_enctheora );
hb_register( &hb_deca52 );
Expand Down
1 change: 0 additions & 1 deletion libhb/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,6 @@ enum
WORK_ENCVOBSUB,
WORK_RENDER,
WORK_ENCAVCODEC,
WORK_ENCXVID,
WORK_ENCX264,
WORK_ENCTHEORA,
WORK_DECA52,
Expand Down
4 changes: 2 additions & 2 deletions libhb/module.defs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
__deps__ := A52DEC BZIP2 FAAC FAAD2 FFMPEG LAME LIBDCA \
LIBDVDREAD LIBDVDNAV LIBMKV LIBOGG LIBSAMPLERATE LIBTHEORA LIBVORBIS \
MP4V2 MPEG2DEC PTHREADW32 X264 XVIDCORE ZLIB
MP4V2 MPEG2DEC PTHREADW32 X264 ZLIB

$(eval $(call import.MODULE.defs,LIBHB,libhb,$(__deps__)))
$(eval $(call import.GCC,LIBHB))
Expand Down Expand Up @@ -89,7 +89,7 @@ LIBHB.lib = $(LIBHB.build/)hb.lib

LIBHB.dll.libs = $(foreach n, \
a52 bz2 avcodec avformat avutil dca dvdnav dvdread faac faad mkv mpeg2 mp3lame mp4v2 \
ogg pthreadGC2 samplerate swscale theora vorbis vorbisenc x264 xvidcore z, \
ogg pthreadGC2 samplerate swscale theora vorbis vorbisenc x264 z, \
$(CONTRIB.build/)lib/lib$(n).a )

LIBHB.GCC.args.extra.dylib++ = -Wl,--out-implib,$(LIBHB.lib)
Expand Down
Loading

0 comments on commit 4106a36

Please sign in to comment.