Skip to content

Commit

Permalink
Make all model.set() calls for the current hit
Browse files Browse the repository at this point in the history
  • Loading branch information
philipwalton committed Oct 27, 2016
1 parent 26f433f commit 0ecd04b
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions test/event-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,9 @@ function requireEventTrackerWithHitFilter() {
throw 'Aborting non-social hits';
}
else {
model.set('nonInteraction', true);
model.set('dimension1', 'foo');
model.set('dimension2', 'bar');
model.set('nonInteraction', true, true);
model.set('dimension1', 'foo', true);
model.set('dimension2', 'bar', true);
}
}
});
Expand Down
6 changes: 3 additions & 3 deletions test/impression-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -640,9 +640,9 @@ function requireImpressionTracker_hitFilter() {
throw 'Aborting hits with ID "foo-1"';
}
else {
model.set('nonInteraction', true);
model.set('dimension1', 'one');
model.set('dimension2', 'two');
model.set('nonInteraction', true, true);
model.set('dimension1', 'one', true);
model.set('dimension2', 'two', true);
}
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/outbound-form-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ function requireOutboundFormTracker_hitFilter() {
throw 'Exclude hits to www.google-analytics.com';
}
else {
model.set('nonInteraction', true);
model.set('nonInteraction', true, true);
}
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/outbound-link-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ function requireOutboundLinkTracker_hitFilter() {
throw 'Exclude hits to www.google-analytics.com';
}
else {
model.set('nonInteraction', true);
model.set('nonInteraction', true, true);
}
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/page-visibility-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,7 @@ function requirePageVisibilityTracker_hitFilter() {
throw 'Exclude changes to visible';
}
else {
model.set('dimension1', 'pageVisibilityTracker');
model.set('dimension1', 'pageVisibilityTracker', true);
}
}
});
Expand Down
2 changes: 1 addition & 1 deletion test/url-change-tracker.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ function requireUrlChangeTrackerTracker_hitFilter() {
throw 'Exclude Foo pages';
}
else {
model.set('dimension1', 'urlChangeTracker');
model.set('dimension1', 'urlChangeTracker', true);
}
}
});
Expand Down

0 comments on commit 0ecd04b

Please sign in to comment.