Remove extraneous output in shapelib and fix a truncated string #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-barnes
force-pushed
the
richard/fix_shapelib
branch
from
1beb58b to
03291c7
Compare
r-barnes
force-pushed
the
richard/fix_shapelib
branch
2 times, most recently
from
48e3831 to
ed8f5c3
Compare
r-barnes
force-pushed
the
richard/fix_shapelib
branch
from
ed8f5c3 to
d17b654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
memcpyinstead ofstrncpyin dbfopen.c to avoid a string truncation warning that otherwise arises. I've imported the fix from upstream.A number of instances of
putsare replaced withdgprintfto avoid warnings about extraneous output from CRAN.