HSI: omap_ssi: Fix refcount leak in ssi_probe

When returning or breaking early from a for_each_available_child_of_node() loop, we need to explicitly call of_node_put() on the child node to possibly release the node. Fixes: b209e04 ("HSI: Introduce OMAP SSI driver") Signed-off-by: Miaoqian Lin <[email protected]> Signed-off-by: Sebastian Reichel <[email protected]>
sajibsrs · Aug 29, 2022 · 9a2ea13 · 9a2ea13
1 parent 77e0ccd
commit 9a2ea13
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
@@ -524,6 +524,7 @@ static int ssi_probe(struct platform_device *pd)
 		if (!childpdev) {
 			err = -ENODEV;
 			dev_err(&pd->dev, "failed to create ssi controller port\n");
+			of_node_put(child);
 			goto out3;
 		}
 	}