SAK-44225 SakaiGrader keep the selected submission #12887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the group ref detection into the firstUpdated lit callback Cleaned up the attribute setting in grader, using ifDefined. Changed viewFilterGroup to selectedGroup. viewFilterGroup sounds like a boolean
ern
changed the title
adrianfish
reviewed
Sep 17, 2024
webcomponents/tool/src/main/frontend/packages/sakai-grader/src/SakaiGrader.js
Outdated
Show resolved
Hide resolved
adrianfish
requested changes
Sep 19, 2024
webcomponents/tool/src/main/frontend/packages/sakai-grader/src/SakaiGrader.js
Outdated
Show resolved
Hide resolved
adrianfish
reviewed
Sep 19, 2024
webcomponents/tool/src/main/frontend/packages/sakai-grader/src/SakaiGrader.js
Outdated
Show resolved
Hide resolved
|
@adrianfish thank you for the suggestions! |
adrianfish
approved these changes
Sep 20, 2024
ern
pushed a commit
that referenced
this pull request
Feb 12, 2025
Co-authored-by: Adrian Fish <[email protected]> (cherry picked from commit 68c418e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After thoroughly testing the previous PR, I found that with the change, the selected student is lost, and the first one is set by default. Similarly (as was already happening), when changing groups, the displayed student is not retained if they are in the group being filtered.