Tests: Use AK_MAKE_DEFAULT_MOVABLE to avoid mistakes in default impls

sakgoyal · Jun 18, 2023 · 2b2e0a4 · 2b2e0a4
1 parent 8ae60dd
commit 2b2e0a4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/Tests/AK/TestQuickSort.cpp b/Tests/AK/TestQuickSort.cpp
@@ -14,12 +14,10 @@ TEST_CASE(sorts_without_copy)
 {
     struct NoCopy {
         AK_MAKE_NONCOPYABLE(NoCopy);
+        AK_MAKE_DEFAULT_MOVABLE(NoCopy);
 
     public:
         NoCopy() = default;
-        NoCopy(NoCopy&&) = default;
-
-        NoCopy& operator=(NoCopy&&) = default;
 
         int value { 0 };
     };

diff --git a/Tests/AK/TestTuple.cpp b/Tests/AK/TestTuple.cpp
@@ -53,9 +53,9 @@ TEST_CASE(no_copy)
 {
     struct NoCopy {
         AK_MAKE_NONCOPYABLE(NoCopy);
+        AK_MAKE_DEFAULT_MOVABLE(NoCopy);
 
     public:
-        NoCopy(NoCopy&&) = default;
         NoCopy() = default;
     };
 

diff --git a/Tests/AK/TestVariant.cpp b/Tests/AK/TestVariant.cpp
@@ -96,10 +96,10 @@ TEST_CASE(move_moves)
 {
     struct NoCopy {
         AK_MAKE_NONCOPYABLE(NoCopy);
+        AK_MAKE_DEFAULT_MOVABLE(NoCopy);
 
     public:
         NoCopy() = default;
-        NoCopy(NoCopy&&) = default;
     };
 
     Variant<NoCopy, int> first_variant { 42 };