feat: drop Node.js 16 (vercel#56896)

### What? BREAKING CHANGE: Bump the minimum required Node.js version. ### Why? Node.js 16 has reached end-of-life in September. Bumped to `18.18.2` since it contained some security-related patches: https://nodejs.org/en/blog/vulnerability/october-2023-security-releases ### How? Bumped `engines` where needed, upgraded the workflows. This will allow us to remove quite a few polyfills, I'll open separate PRs for those.
saltcod · Oct 16, 2023 · 1ff7f07 · 1ff7f07
1 parent 9fda481
commit 1ff7f07
Show file tree

Hide file tree

Showing 22 changed files with 34 additions and 65 deletions.
diff --git a/.github/actions/needs-triage/action.yaml b/.github/actions/needs-triage/action.yaml
@@ -2,5 +2,5 @@ name: 'Issue auto label'
 description: 'vercel/next.js specific auto-labeling action'
 author: 'Next.js team'
 runs:
-  using: 'node16'
+  using: 'node20'
   main: 'index.js'
diff --git a/.github/actions/next-stats-action/Dockerfile b/.github/actions/next-stats-action/Dockerfile
@@ -9,7 +9,7 @@ RUN apt install unzip wget curl nano htop screen build-essential pkg-config libs
 
 RUN ln $(which python3) /usr/bin/python
 
-RUN curl -sfLS https://install-node.vercel.app/v18 | bash -s -- -f
+RUN curl -sfLS https://install-node.vercel.app/v18.18.2 | bash -s -- -f
 RUN corepack enable
 
 WORKDIR /next-stats

diff --git a/.github/actions/next-stats-action/package.json b/.github/actions/next-stats-action/package.json
@@ -18,7 +18,7 @@
     "typescript": "5.1.6"
   },
   "engines": {
-    "node": ">=16.14.0",
+    "node": ">=18.18.2",
     "pnpm": "8.9.0"
   },
   "packageManager": "[email protected]"

diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml
@@ -8,8 +8,7 @@ on:
 env:
   NAPI_CLI_VERSION: 2.16.2
   TURBO_VERSION: 1.10.9
-  NODE_MAINTENANCE_VERSION: 16
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
   CARGO_PROFILE_RELEASE_LTO: 'true'
   TURBO_TEAM: 'vercel'
   TURBO_REMOTE_ONLY: 'true'

diff --git a/.github/workflows/build_and_test.yml b/.github/workflows/build_and_test.yml
@@ -9,8 +9,7 @@ on:
 env:
   NAPI_CLI_VERSION: 2.14.7
   TURBO_VERSION: 1.10.9
-  NODE_MAINTENANCE_VERSION: 16
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
   TEST_CONCURRENCY: 8
   # disable backtrace for test snapshots
   RUST_BACKTRACE: 0
@@ -147,7 +146,7 @@ jobs:
         group: [1, 2, 3, 4, 5]
     uses: ./.github/workflows/build_reusable.yml
     with:
-      nodeVersion: 16
+      nodeVersion: 18.18.2
       skipForDocsOnly: 'yes'
       afterBuild: RUST_BACKTRACE=0 NEXT_EXTERNAL_TESTS_FILTERS="$(pwd)/test/turbopack-tests-manifest.json" TURBOPACK=1 node run-tests.js --timings -g ${{ matrix.group }}/5 -c ${TEST_CONCURRENCY} --type integration
     secrets: inherit
@@ -212,7 +211,7 @@ jobs:
 
     uses: ./.github/workflows/build_reusable.yml
     with:
-      nodeVersion: 16
+      nodeVersion: 18.18.2
       skipForDocsOnly: 'yes'
       afterBuild: node run-tests.js --timings -g ${{ matrix.group }}/12 -c ${TEST_CONCURRENCY} --type integration
     secrets: inherit

diff --git a/.github/workflows/build_reusable.yml b/.github/workflows/build_reusable.yml
@@ -57,8 +57,7 @@ on:
 env:
   NAPI_CLI_VERSION: 2.14.7
   TURBO_VERSION: 1.10.9
-  NODE_MAINTENANCE_VERSION: 16
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
   TEST_CONCURRENCY: 8
   # disable backtrace for test snapshots
   RUST_BACKTRACE: 0

diff --git a/.github/workflows/code_freeze.yml b/.github/workflows/code_freeze.yml
@@ -18,8 +18,7 @@ name: Code Freeze
 env:
   NAPI_CLI_VERSION: 2.14.7
   TURBO_VERSION: 1.10.9
-  NODE_MAINTENANCE_VERSION: 16
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
 
 jobs:
   start:

diff --git a/.github/workflows/pull_request_stats.yml b/.github/workflows/pull_request_stats.yml
@@ -7,8 +7,7 @@ name: Generate Pull Request Stats
 env:
   NAPI_CLI_VERSION: 2.14.7
   TURBO_VERSION: 1.10.9
-  NODE_MAINTENANCE_VERSION: 16
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
   TEST_CONCURRENCY: 6
 
   TURBO_TEAM: 'vercel'

diff --git a/.github/workflows/test_e2e_deploy.yml b/.github/workflows/test_e2e_deploy.yml
@@ -16,8 +16,7 @@ jobs:
       DATADOG_API_KEY: ${{ secrets.DATA_DOG_API_KEY }}
       NAPI_CLI_VERSION: 2.16.2
       TURBO_VERSION: 1.10.9
-      NODE_MAINTENANCE_VERSION: 16
-      NODE_LTS_VERSION: 18
+      NODE_LTS_VERSION: 20
       CARGO_PROFILE_RELEASE_LTO: 'true'
       TURBO_TEAM: 'vercel'
       TURBO_REMOTE_ONLY: 'true'

diff --git a/.github/workflows/test_examples.yml b/.github/workflows/test_examples.yml
@@ -25,7 +25,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [16, 18]
+        node: [18, 20]
     steps:
       - uses: actions/checkout@v3
         with:
@@ -37,7 +37,7 @@ jobs:
       - name: Setup node
         uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
           check-latest: true
       - run: corepack enable
 

diff --git a/.github/workflows/trigger_release.yml b/.github/workflows/trigger_release.yml
@@ -30,8 +30,7 @@ name: Trigger Release
 env:
   NAPI_CLI_VERSION: 2.14.7
   TURBO_VERSION: 1.10.9
-  NODE_MAINTENANCE_VERSION: 16
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
 
 jobs:
   start:

diff --git a/.github/workflows/update_fonts_data.yml b/.github/workflows/update_fonts_data.yml
@@ -8,7 +8,7 @@ on:
   workflow_dispatch:
 
 env:
-  NODE_LTS_VERSION: 18
+  NODE_LTS_VERSION: 20
 
 jobs:
   create-pull-request:

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -34,7 +34,7 @@ pr:
 variables:
   PNPM_CACHE_FOLDER: $(Pipeline.Workspace)/.pnpm-store
   NEXT_TELEMETRY_DISABLED: '1'
-  node_16_version: ^16.14.0
+  node_version: ^18.18.2
 
 stages:
   - stage: Test
@@ -45,7 +45,7 @@ stages:
         steps:
           - task: NodeTool@0
             inputs:
-              versionSpec: $(node_16_version)
+              versionSpec: $(node_version)
             displayName: 'Install Node.js'
 
           - bash: |
@@ -84,7 +84,7 @@ stages:
 
           - task: NodeTool@0
             inputs:
-              versionSpec: $(node_16_version)
+              versionSpec: $(node_version)
             displayName: 'Install Node.js'
 
           - bash: |
@@ -117,7 +117,7 @@ stages:
         steps:
           - task: NodeTool@0
             inputs:
-              versionSpec: $(node_16_version)
+              versionSpec: $(node_version)
             displayName: 'Install Node.js'
 
           - bash: |
@@ -154,7 +154,7 @@ stages:
         steps:
           - task: NodeTool@0
             inputs:
-              versionSpec: $(node_16_version)
+              versionSpec: $(node_version)
             displayName: 'Install Node.js'
 
           - bash: |

diff --git a/docs/04-architecture/supported-browsers.mdx b/docs/04-architecture/supported-browsers.mdx
@@ -57,10 +57,6 @@ Next.js allows you to use the latest JavaScript features out of the box. In addi
 - [Class Fields](https://github.com/tc39/proposal-class-fields) and [Static Properties](https://github.com/tc39/proposal-static-class-features) (part of stage 3 proposal)
 - and more!
 
-### Server-Side Polyfills
-
-In addition to `fetch()` on the client-side, Next.js polyfills `fetch()` in the Node.js environment where it's not yet available. It uses `undici`, the same implementation that Node.js itself uses. You can use `fetch()` in your server code (such as `getStaticProps`/`getServerSideProps`) without using polyfills such as `isomorphic-unfetch` or `node-fetch`.
-
 ### TypeScript Features
 
 Next.js has built-in TypeScript support. [Learn more here](/docs/pages/building-your-application/configuring/typescript).

diff --git a/package.json b/package.json
@@ -249,7 +249,7 @@
     "@types/react-dom": "18.2.4"
   },
   "engines": {
-    "node": ">=16.14.0",
+    "node": ">=18.18.2",
     "pnpm": "8.9.0"
   },
   "packageManager": "[email protected]"

diff --git a/packages/create-next-app/package.json b/packages/create-next-app/package.json
@@ -52,6 +52,6 @@
     "validate-npm-package-name": "3.0.0"
   },
   "engines": {
-    "node": ">=16.14.0"
+    "node": ">=18.18.2"
   }
 }
diff --git a/packages/next/package.json b/packages/next/package.json
@@ -316,6 +316,6 @@
     "zod": "3.22.3"
   },
   "engines": {
-    "node": ">=16.14.0"
+    "node": ">=18.18.2"
   }
 }
diff --git a/packages/next/src/bin/next.ts b/packages/next/src/bin/next.ts
@@ -94,22 +94,6 @@ if (process.env.NODE_ENV) {
 ;(process.env as any).NODE_ENV = process.env.NODE_ENV || defaultEnv
 ;(process.env as any).NEXT_RUNTIME = 'nodejs'
 
-// x-ref: https://github.com/vercel/next.js/pull/34688#issuecomment-1047994505
-if (process.versions.pnp === '3') {
-  const nodeVersionParts = process.versions.node
-    .split('.')
-    .map((v) => Number(v))
-
-  if (
-    nodeVersionParts[0] < 16 ||
-    (nodeVersionParts[0] === 16 && nodeVersionParts[1] < 14)
-  ) {
-    log.warn(
-      'Node.js 16.14+ is required for Yarn PnP 3.20+. More info: https://github.com/vercel/next.js/pull/34688#issuecomment-1047994505'
-    )
-  }
-}
-
 // Make sure commands gracefully respect termination signals (e.g. from Docker)
 // Allow the graceful termination to be manually configurable
 if (!process.env.NEXT_MANUAL_SIG_HANDLE && command !== 'dev') {

diff --git a/test/.stats-app/package.json b/test/.stats-app/package.json
@@ -8,7 +8,7 @@
     "react-dom": "latest"
   },
   "engines": {
-    "node": ">=16.14.0",
+    "node": ">=18.18.2",
     "pnpm": "8.9.0"
   },
   "packageManager": "[email protected]"

diff --git a/test/e2e/app-dir/actions/app-action-progressive-enhancement.test.ts b/test/e2e/app-dir/actions/app-action-progressive-enhancement.test.ts
@@ -24,7 +24,7 @@ createNextDescribe(
 
       await check(() => {
         return browser.eval('window.location.pathname + window.location.search')
-      }, '/header?name=test&constructor=FormData&hidden-info=hi')
+      }, '/header?name=test&constructor=_FormData&hidden-info=hi')
     })
 
     it('should support actions from client without JS', async () => {
@@ -39,7 +39,7 @@ createNextDescribe(
 
       await check(() => {
         return browser.eval('window.location.pathname + window.location.search')
-      }, '/header?name=test&constructor=FormData&hidden-info=hi')
+      }, '/header?name=test&constructor=_FormData&hidden-info=hi')
     })
   }
 )
diff --git a/test/e2e/app-dir/actions/app-action.test.ts b/test/e2e/app-dir/actions/app-action.test.ts
@@ -134,7 +134,7 @@ createNextDescribe(
 
       await check(() => {
         return browser.eval('window.location.pathname + window.location.search')
-      }, '/header?name=test&constructor=FormData&hidden-info=hi')
+      }, '/header?name=test&constructor=_FormData&hidden-info=hi')
     })
 
     it('should support .bind', async () => {

diff --git a/test/e2e/edge-compiler-can-import-blob-assets/index.test.ts b/test/e2e/edge-compiler-can-import-blob-assets/index.test.ts
@@ -5,7 +5,10 @@ import path from 'path'
 import { promises as fs } from 'fs'
 import { readJson } from 'fs-extra'
 
-describe('Edge Compiler can import asset assets', () => {
+// TODO: `node-fetch` hangs on some of these tests in Node.js.
+// Re-enable when `node-fetch` is dropped.
+// See: https://github.com/vercel/next.js/pull/55112
+describe.skip('Edge Compiler can import asset assets', () => {
   let next: NextInstance
 
   // TODO: remove after this is supported for deploy
@@ -29,16 +32,9 @@ describe('Edge Compiler can import asset assets', () => {
   })
 
   it('allows to fetch a remote URL with a path and basename', async () => {
-    const response = await fetchViaHTTP(
-      next.url,
-      '/api/edge',
-      {
-        handler: 'remote-with-base',
-      },
-      {
-        compress: true,
-      }
-    )
+    const response = await fetchViaHTTP(next.url, '/api/edge', {
+      handler: 'remote-with-base',
+    })
     expect(await response.text()).toContain('Example Domain')
   })