Some splits for better modding options #49
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onemantooo
commented
Jan 11, 2024
| return GetGame().CreateObject(GetRandomAI(), pos); | ||
| } | ||
|
|
||
| private void ConfigureAi(eAIBase ai, vector pos) { | ||
| ai.SetPosition(pos); |
There was a problem hiding this comment.
Not sure why is this needed cos we already passed position to CreateObject but kept it untouched.
There was a problem hiding this comment.
Options to set the specific AI class names used to spawn the AI patrol units have been added in the last update:
|
In the latest update now, thank you for the suggestion <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Recently i've tried to add some options to spawned patrols, and one caused a problem - i wanted to add an options to spawn only male or only female AIs via my mod configuration. But to accomplish that - i need to fully override or copy
SpawnAImethod which causes obvious problem - it can break Expansion functionality after some of your updates.So i took all my bravery to send you this PR. It's just splits
SpawnAIto few separated methods.If you won't accept this one, maybe i can send you a PR with male/female functionality?