Tags: samherrmann/cobra
Tags
Fix flag completion (spf13#1438) * Fix flag completion The flag completion functions should not be stored in the root cmd. There is no requirement that the root cmd should be the same when `RegisterFlagCompletionFunc` was called. Storing the flags there does not work when you add the the flags to your cmd struct before you add the cmd to the parent/root cmd. The flags can no longer be found in the rigth place when the completion command is called and thus the flag completion does not work. Also spf13#1423 claims that this would be thread safe but we still have a map which will fail when accessed concurrently. To truly fix this issue use a RWMutex. Fixes spf13#1437 Fixes spf13#1320 Signed-off-by: Paul Holzinger <[email protected]> * Fix trailing whitespaces in fish comp scripts Signed-off-by: Paul Holzinger <[email protected]>
Fix documentation (spf13#1434) Signed-off-by: Marc Khouzam <[email protected]>
fix manpage building with new go-md2man (spf13#1255) This addresses spf13#1049 by changing the format of the generated Markdown input.
Add example for making persistent flags required (spf13#1135)
Fish completion using Go completion (spf13#1048) Signed-off-by: Marc Khouzam <[email protected]>
Partial Revert of spf13#922 (spf13#1068) Issue Reference: spf13#1056 spf13#922 introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
Partial Revert of spf13#922 (spf13#1068) Issue Reference: spf13#1056 spf13#922 introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
PreviousNext