Skip to content

Commit

Permalink
Move ALTQ from contrib to net/altq. The ALTQ code is for many years
Browse files Browse the repository at this point in the history
discontinued by its initial authors. In FreeBSD the code was already
slightly edited during the pf(4) SMP project. It is about to be edited
more in the projects/ifnet. Moving out of contrib also allows to remove
several hacks to the make glue.

Reviewed by:	net@
  • Loading branch information
glebius committed Apr 16, 2015
1 parent 7c0b0b9 commit 772e66a
Show file tree
Hide file tree
Showing 35 changed files with 122 additions and 113 deletions.
15 changes: 15 additions & 0 deletions ObsoleteFiles.inc
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,21 @@
# xargs -n1 | sort | uniq -d;
# done

# 20150416: ALTQ moved to net/altq
OLD_FILES+=usr/include/altq/altq_rmclass_debug.h
OLD_FILES+=usr/include/altq/altq.h
OLD_FILES+=usr/include/altq/altq_cdnr.h
OLD_FILES+=usr/include/altq/altq_hfsc.h
OLD_FILES+=usr/include/altq/altq_priq.h
OLD_FILES+=usr/include/altq/altqconf.h
OLD_FILES+=usr/include/altq/altq_classq.h
OLD_FILES+=usr/include/altq/altq_red.h
OLD_FILES+=usr/include/altq/if_altq.h
OLD_FILES+=usr/include/altq/altq_var.h
OLD_FILES+=usr/include/altq/altq_rmclass.h
OLD_FILES+=usr/include/altq/altq_cbq.h
OLD_FILES+=usr/include/altq/altq_rio.h
OLD_DIRS+=usr/include/altq
# 20150410
OLD_FILES+=usr/share/doc/usd/10.exref/paper.ascii.gz
OLD_FILES+=usr/share/doc/usd/10.exref/summary.ascii.gz
Expand Down
4 changes: 2 additions & 2 deletions etc/mtree/BSD.include.dist
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@

/set type=dir uname=root gname=wheel mode=0755
.
altq
..
arpa
..
atf-c
Expand Down Expand Up @@ -254,6 +252,8 @@
..
..
net
altq
..
..
net80211
..
Expand Down
11 changes: 2 additions & 9 deletions include/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ LSUBDIRS= cam/ata cam/scsi \
geom/cache geom/concat geom/eli geom/gate geom/journal geom/label \
geom/mirror geom/mountver geom/multipath geom/nop \
geom/raid geom/raid3 geom/shsec geom/stripe geom/virstor \
net/altq \
netgraph/atm netgraph/netflow \
security/audit \
security/mac_biba security/mac_bsdextended security/mac_lomac \
Expand Down Expand Up @@ -144,7 +145,7 @@ compat:
-p ${DESTDIR}${INCLUDEDIR}

copies:
.for i in ${LDIRS} ${LSUBDIRS} ${LSUBSUBDIRS} altq crypto machine machine/pc \
.for i in ${LDIRS} ${LSUBDIRS} ${LSUBSUBDIRS} crypto machine machine/pc \
${_MARCHS}
.if exists(${DESTDIR}${INCLUDEDIR}/$i)
cd ${DESTDIR}${INCLUDEDIR}/$i; \
Expand Down Expand Up @@ -179,9 +180,6 @@ copies:
cd ${.CURDIR}/../sys/dev/pci; \
${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 pcireg.h \
${DESTDIR}${INCLUDEDIR}/dev/pci
cd ${.CURDIR}/../sys/contrib/altq/altq; \
${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 *.h \
${DESTDIR}${INCLUDEDIR}/altq
cd ${.CURDIR}/../sys/fs/cd9660/; \
${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 *.h \
${DESTDIR}${INCLUDEDIR}/isofs/cd9660
Expand Down Expand Up @@ -279,11 +277,6 @@ symlinks:
ln -fs ../../../../../sys/$i/$$h ${DESTDIR}${INCLUDEDIR}/$i; \
done
.endfor
cd ${.CURDIR}/../sys/contrib/altq/altq; \
for h in *.h; do \
ln -fs ../../../sys/contrib/altq/altq/$$h \
${DESTDIR}${INCLUDEDIR}/altq; \
done
.if ${MK_IPFILTER} != "no"
cd ${.CURDIR}/../sys/contrib/ipfilter/netinet; \
for h in *.h; do \
Expand Down
8 changes: 4 additions & 4 deletions sbin/pfctl/parse.y
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ __FBSDID("$FreeBSD$");
#include <netinet/icmp6.h>
#include <net/pfvar.h>
#include <arpa/inet.h>
#include <altq/altq.h>
#include <altq/altq_cbq.h>
#include <altq/altq_priq.h>
#include <altq/altq_hfsc.h>
#include <net/altq/altq.h>
#include <net/altq/altq_cbq.h>
#include <net/altq/altq_priq.h>
#include <net/altq/altq_hfsc.h>

#include <stdio.h>
#include <unistd.h>
Expand Down
2 changes: 1 addition & 1 deletion sbin/pfctl/pfctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ __FBSDID("$FreeBSD$");
#include <netinet/in.h>
#include <net/pfvar.h>
#include <arpa/inet.h>
#include <altq/altq.h>
#include <net/altq/altq.h>
#include <sys/sysctl.h>

#include <err.h>
Expand Down
8 changes: 4 additions & 4 deletions sbin/pfctl/pfctl_altq.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,10 @@ __FBSDID("$FreeBSD$");
#include <string.h>
#include <unistd.h>

#include <altq/altq.h>
#include <altq/altq_cbq.h>
#include <altq/altq_priq.h>
#include <altq/altq_hfsc.h>
#include <net/altq/altq.h>
#include <net/altq/altq_cbq.h>
#include <net/altq/altq_priq.h>
#include <net/altq/altq_hfsc.h>

#include "pfctl_parser.h"
#include "pfctl.h"
Expand Down
8 changes: 4 additions & 4 deletions sbin/pfctl/pfctl_qstats.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ __FBSDID("$FreeBSD$");
#include <string.h>
#include <unistd.h>

#include <altq/altq.h>
#include <altq/altq_cbq.h>
#include <altq/altq_priq.h>
#include <altq/altq_hfsc.h>
#include <net/altq/altq.h>
#include <net/altq/altq_cbq.h>
#include <net/altq/altq_priq.h>
#include <net/altq/altq_hfsc.h>

#include "pfctl.h"
#include "pfctl_parser.h"
Expand Down
16 changes: 8 additions & 8 deletions sys/conf/files
Original file line number Diff line number Diff line change
Expand Up @@ -247,14 +247,6 @@ compat/freebsd32/freebsd32_ioctl.c optional compat_freebsd32
compat/freebsd32/freebsd32_misc.c optional compat_freebsd32
compat/freebsd32/freebsd32_syscalls.c optional compat_freebsd32
compat/freebsd32/freebsd32_sysent.c optional compat_freebsd32
contrib/altq/altq/altq_cbq.c optional altq
contrib/altq/altq/altq_cdnr.c optional altq
contrib/altq/altq/altq_hfsc.c optional altq
contrib/altq/altq/altq_priq.c optional altq
contrib/altq/altq/altq_red.c optional altq
contrib/altq/altq/altq_rio.c optional altq
contrib/altq/altq/altq_rmclass.c optional altq
contrib/altq/altq/altq_subr.c optional altq
contrib/dev/acpica/common/ahids.c optional acpi acpi_debug
contrib/dev/acpica/common/ahuuids.c optional acpi acpi_debug
contrib/dev/acpica/components/debugger/dbcmds.c optional acpi acpi_debug
Expand Down Expand Up @@ -3272,6 +3264,14 @@ libkern/strtoul.c standard
libkern/strtouq.c standard
libkern/strvalid.c standard
libkern/timingsafe_bcmp.c standard
net/altq/altq_cbq.c optional altq
net/altq/altq_cdnr.c optional altq
net/altq/altq_hfsc.c optional altq
net/altq/altq_priq.c optional altq
net/altq/altq_red.c optional altq
net/altq/altq_rio.c optional altq
net/altq/altq_rmclass.c optional altq
net/altq/altq_subr.c optional altq
net/bpf.c standard
net/bpf_buffer.c optional bpf
net/bpf_jitter.c optional bpf_jitter
Expand Down
7 changes: 2 additions & 5 deletions sys/conf/kern.pre.mk
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,10 @@ NOSTDINC= -nostdinc

INCLUDES= ${NOSTDINC} ${INCLMAGIC} -I. -I$S

# This hack lets us use the OpenBSD altq code without spamming a new
# include path into contrib'ed source files.
INCLUDES+= -I$S/contrib/altq

.if make(depend) || make(kernel-depend)

# ... and the same for ipfilter
# This hack lets us use the ipfilter code without spamming a new
# include path into contrib'ed source files.
INCLUDES+= -I$S/contrib/ipfilter

# ... and the same for ath
Expand Down
4 changes: 0 additions & 4 deletions sys/conf/kmod.mk
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ CFLAGS+= -DHAVE_KERNEL_OPTION_HEADERS -include ${KERNBUILDDIR}/opt_global.h
# set because there are no standard paths for non-headers.
CFLAGS+= -I. -I${SYSDIR}

# Add -I path for altq headers as they are included via net/if_var.h
# for example.
CFLAGS+= -I${SYSDIR}/contrib/altq

CFLAGS.gcc+= -finline-limit=${INLINE_LIMIT}
CFLAGS.gcc+= -fms-extensions
CFLAGS.gcc+= --param inline-unit-growth=100
Expand Down
2 changes: 1 addition & 1 deletion sys/contrib/altq/altq/altq.h → sys/net/altq/altq.h
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ struct pktcntr {
#endif /* ALTQ3_COMPAT */

#ifdef _KERNEL
#include <altq/altq_var.h>
#include <net/altq/altq_var.h>
#endif

#endif /* _ALTQ_ALTQ_H_ */
6 changes: 3 additions & 3 deletions sys/contrib/altq/altq/altq_cbq.c → sys/net/altq/altq_cbq.c
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@
#include <netpfil/pf/pf.h>
#include <netpfil/pf/pf_altq.h>
#include <netpfil/pf/pf_mtag.h>
#include <altq/altq.h>
#include <altq/altq_cbq.h>
#include <net/altq/altq.h>
#include <net/altq/altq_cbq.h>
#ifdef ALTQ3_COMPAT
#include <altq/altq_conf.h>
#include <net/altq/altq_conf.h>
#endif

#ifdef ALTQ3_COMPAT
Expand Down
15 changes: 8 additions & 7 deletions sys/contrib/altq/altq/altq_cbq.h → sys/net/altq/altq_cbq.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/* $KAME: altq_cbq.h,v 1.12 2003/10/03 05:05:15 kjc Exp $ */

/*
/*-
* Copyright (c) Sun Microsystems, Inc. 1993-1998 All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
Expand Down Expand Up @@ -28,15 +26,18 @@
* provided "as is" without express or implied warranty of any kind.
*
* These notices must be retained in any copies of any part of this software.
*
* $KAME: altq_cbq.h,v 1.12 2003/10/03 05:05:15 kjc Exp $
* $FreeBSD$
*/

#ifndef _ALTQ_ALTQ_CBQ_H_
#define _ALTQ_ALTQ_CBQ_H_

#include <altq/altq.h>
#include <altq/altq_rmclass.h>
#include <altq/altq_red.h>
#include <altq/altq_rio.h>
#include <net/altq/altq.h>
#include <net/altq/altq_rmclass.h>
#include <net/altq/altq_red.h>
#include <net/altq/altq_rio.h>

#ifdef __cplusplus
extern "C" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,12 +55,12 @@
#include <netinet/ip6.h>
#endif

#include <altq/if_altq.h>
#include <altq/altq.h>
#include <net/altq/if_altq.h>
#include <net/altq/altq.h>
#ifdef ALTQ3_COMPAT
#include <altq/altq_conf.h>
#include <net/altq/altq_conf.h>
#endif
#include <altq/altq_cdnr.h>
#include <net/altq/altq_cdnr.h>

#ifdef ALTQ3_COMPAT
/*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/* $KAME: altq_cdnr.h,v 1.9 2003/07/10 12:07:48 kjc Exp $ */

/*
/*-
* Copyright (C) 1999-2002
* Sony Computer Science Laboratories Inc. All rights reserved.
*
Expand All @@ -24,12 +22,15 @@
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $KAME: altq_cdnr.h,v 1.9 2003/07/10 12:07:48 kjc Exp $
* $FreeBSD$
*/

#ifndef _ALTQ_ALTQ_CDNR_H_
#define _ALTQ_ALTQ_CDNR_H_

#include <altq/altq.h>
#include <net/altq/altq.h>

/*
* traffic conditioner element types
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,10 @@
#include <netpfil/pf/pf.h>
#include <netpfil/pf/pf_altq.h>
#include <netpfil/pf/pf_mtag.h>
#include <altq/altq.h>
#include <altq/altq_hfsc.h>
#include <net/altq/altq.h>
#include <net/altq/altq_hfsc.h>
#ifdef ALTQ3_COMPAT
#include <altq/altq_conf.h>
#include <net/altq/altq_conf.h>
#endif

/*
Expand Down
15 changes: 8 additions & 7 deletions sys/contrib/altq/altq/altq_hfsc.h → sys/net/altq/altq_hfsc.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
/* $KAME: altq_hfsc.h,v 1.12 2003/12/05 05:40:46 kjc Exp $ */

/*
/*-
* Copyright (c) 1997-1999 Carnegie Mellon University. All Rights Reserved.
*
* Permission to use, copy, modify, and distribute this software and
Expand Down Expand Up @@ -28,14 +26,17 @@
* software to return any improvements or extensions that they make,
* and to grant Carnegie Mellon the rights to redistribute these
* changes without encumbrance.
*
* $KAME: altq_hfsc.h,v 1.12 2003/12/05 05:40:46 kjc Exp $
* $FreeBSD$
*/
#ifndef _ALTQ_ALTQ_HFSC_H_
#define _ALTQ_ALTQ_HFSC_H_

#include <altq/altq.h>
#include <altq/altq_classq.h>
#include <altq/altq_red.h>
#include <altq/altq_rio.h>
#include <net/altq/altq.h>
#include <net/altq/altq_classq.h>
#include <net/altq/altq_red.h>
#include <net/altq/altq_rio.h>

#ifdef __cplusplus
extern "C" {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@
#include <netpfil/pf/pf.h>
#include <netpfil/pf/pf_altq.h>
#include <netpfil/pf/pf_mtag.h>
#include <altq/altq.h>
#include <net/altq/altq.h>
#ifdef ALTQ3_COMPAT
#include <altq/altq_conf.h>
#include <net/altq/altq_conf.h>
#endif
#include <altq/altq_priq.h>
#include <net/altq/altq_priq.h>

/*
* function prototypes
Expand Down
14 changes: 8 additions & 6 deletions sys/contrib/altq/altq/altq_priq.h → sys/net/altq/altq_priq.h
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
/* $KAME: altq_priq.h,v 1.7 2003/10/03 05:05:15 kjc Exp $ */
/*
/*-
* Copyright (C) 2000-2003
* Sony Computer Science Laboratories Inc. All rights reserved.
*
Expand All @@ -23,15 +22,18 @@
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*
* $KAME: altq_priq.h,v 1.7 2003/10/03 05:05:15 kjc Exp $
* $FreeBSD$
*/

#ifndef _ALTQ_ALTQ_PRIQ_H_
#define _ALTQ_ALTQ_PRIQ_H_

#include <altq/altq.h>
#include <altq/altq_classq.h>
#include <altq/altq_red.h>
#include <altq/altq_rio.h>
#include <net/altq/altq.h>
#include <net/altq/altq_classq.h>
#include <net/altq/altq_red.h>
#include <net/altq/altq_rio.h>

#ifdef __cplusplus
extern "C" {
Expand Down
8 changes: 4 additions & 4 deletions sys/contrib/altq/altq/altq_red.c → sys/net/altq/altq_red.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,12 +98,12 @@
#include <netpfil/pf/pf.h>
#include <netpfil/pf/pf_altq.h>
#include <netpfil/pf/pf_mtag.h>
#include <altq/altq.h>
#include <altq/altq_red.h>
#include <net/altq/altq.h>
#include <net/altq/altq_red.h>
#ifdef ALTQ3_COMPAT
#include <altq/altq_conf.h>
#include <net/altq/altq_conf.h>
#ifdef ALTQ_FLOWVALVE
#include <altq/altq_flowvalve.h>
#include <net/altq/altq_flowvalve.h>
#endif
#endif

Expand Down
Loading

0 comments on commit 772e66a

Please sign in to comment.