Skip to content

Commit

Permalink
bectl(8) test: Force destroy the zpool in cleanup
Browse files Browse the repository at this point in the history
This is a wild guess as to why bectl tests failed once upon a time in CI,
given no apparent way to see a transcript of cleanup routines with Kyua. The
bectl tests construct a new, clean zpool for every test. The failure
indicated was because of a mount that was leftover from a previous test, but
the previous test had succeeded so it's not clear how the mount remained
leftover unless the `zpool get health ${pool}` had somehow failed.

MFC after:	1 week
  • Loading branch information
kevans91 committed Jan 29, 2019
1 parent e42b993 commit bf05ccc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sbin/bectl/tests/bectl_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ bectl_cleanup()
zpool=$1

if zpool get health ${zpool} >/dev/null 2>&1; then
zpool destroy ${zpool}
zpool destroy -f ${zpool}
fi
}

Expand Down

0 comments on commit bf05ccc

Please sign in to comment.