Clarify qt settings #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tool inherits from both `QDialog` and `WindowState` yet only `QDialog` was given in the docs. This is misleading because the `_save_state()` and `_restore_state()` methods come from `WindowState`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
WindowStateas a parent ofTool.I would also like to mention the need to attach
save_state()to a closing signal (e.g.self.finished.connect(self.save_state))) and howself._restore_state()gets called byself.restore_state(). However, instead of documenting it, I wonder whether we should just add the connection and restore call to adef __init__ofWindowState. That way, save state will always be called on close and restore state always called on start. Thoughts?