perf: optimize getShapeById

samuelbaizg · Dec 19, 2022 · d6bd495 · d6bd495
1 parent 0203179
commit d6bd495
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/tldraw/packages/core/src/lib/TLApp/TLApp.ts b/tldraw/packages/core/src/lib/TLApp/TLApp.ts
@@ -318,7 +318,7 @@ export class TLApp<
   /* --------------------- Shapes --------------------- */
 
   getShapeById = <T extends S>(id: string, pageId = this.currentPage.id): T | undefined => {
-    const shape = this.getPageById(pageId)?.shapes.find(shape => shape.id === id) as T
+    const shape = this.getPageById(pageId)?.shapesById[id] as T
     return shape
   }
 

diff --git a/tldraw/packages/core/src/lib/TLPage/TLPage.ts b/tldraw/packages/core/src/lib/TLPage/TLPage.ts
@@ -85,6 +85,10 @@ export class TLPage<S extends TLShape = TLShape, E extends TLEventMap = TLEventM
     }
   }
 
+  @computed get shapesById() {
+    return Object.fromEntries(this.shapes.map(shape => [shape.id, shape]))
+  }
+
   @observable nonce = 0
 
   @action bump = () => {