thermal_monitor: fix negative loop bounds issue

unsigned integers trip and trip_count should be signed since thermaldInterface.getTripCountForZone(zone) can return a -ve. Fixes CoverityScan CID 150269: "CID 150269 (intel#1 of 1): Negative loop bound (NEGATIVE_RETURNS) negative_returns: Using unsigned variable trip_count in a loop exit condition." Signed-off-by: Colin Ian King <[email protected]>
sandsmark · Jul 11, 2016 · 244b173 · 244b173
1 parent baaee2d
commit 244b173
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/tools/thermal_monitor/mainwindow.cpp b/tools/thermal_monitor/mainwindow.cpp
@@ -187,9 +187,9 @@ void MainWindow::displayTemperature(QCustomPlot *customPlot)
 
         // Draw a dashed horz line for each min valid trip temperature
         QVector<QCPItemLine *> these_trips;
-        uint trip_count = thermaldInterface.getTripCountForZone(zone);
+        int trip_count = thermaldInterface.getTripCountForZone(zone);
         if (trip_count > 0) {
-            for (uint trip = 0; trip < trip_count; trip++){
+            for (int trip = 0; trip < trip_count; trip++){
                 QCPItemLine *line = new QCPItemLine(customPlot);
                 customPlot->addItem(line);
                 temp = thermaldInterface.getTripTempForZone(zone, trip);