Switch from istanbul to v8 for vitest coverage provider (iTwin#7252)

sangyuruo · Oct 9, 2024 · 7e6467d · 7e6467d
1 parent 612f94f
commit 7e6467d
Show file tree

Hide file tree

Showing 11 changed files with 59 additions and 40 deletions.
diff --git a/common/changes/@itwin/core-bentley/nam-vitest-v8-coverage_2024-10-09-19-51.json b/common/changes/@itwin/core-bentley/nam-vitest-v8-coverage_2024-10-09-19-51.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-bentley",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-bentley"
+}
diff --git a/common/changes/@itwin/core-common/nam-vitest-v8-coverage_2024-10-09-19-51.json b/common/changes/@itwin/core-common/nam-vitest-v8-coverage_2024-10-09-19-51.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-common",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-common"
+}
diff --git a/common/changes/@itwin/core-geometry/nam-vitest-v8-coverage_2024-10-09-19-51.json b/common/changes/@itwin/core-geometry/nam-vitest-v8-coverage_2024-10-09-19-51.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@itwin/core-geometry",
+      "comment": "",
+      "type": "none"
+    }
+  ],
+  "packageName": "@itwin/core-geometry"
+}
diff --git a/common/config/rush/browser-approved-packages.json b/common/config/rush/browser-approved-packages.json
@@ -387,8 +387,8 @@
       "allowedCategories": [ "internal" ]
     },
     {
-      "name": "@vitest/coverage-istanbul",
-      "allowedCategories": [ "backend", "common" ]
+      "name": "@vitest/coverage-v8",
+      "allowedCategories": [ "common" ]
     },
     {
       "name": "@xmldom/xmldom",

diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/core/bentley/package.json b/core/bentley/package.json
@@ -38,7 +38,7 @@
     "@itwin/eslint-plugin": "^4.0.2",
     "@opentelemetry/api": "1.0.4",
     "@types/node": "~18.16.20",
-    "@vitest/coverage-istanbul": "^2.1.0",
+    "@vitest/coverage-v8": "^2.1.0",
     "eslint": "^8.56.0",
     "rimraf": "^3.0.2",
     "typescript": "~5.3.3",

diff --git a/core/bentley/vitest.config.mts b/core/bentley/vitest.config.mts
@@ -3,7 +3,7 @@ export default defineConfig({
   test: {
     dir: "src",
     coverage: {
-      provider: "istanbul", // akin to nyc
+      provider: "v8",
       include: [
         "src/**/*"
       ],

diff --git a/core/common/package.json b/core/common/package.json
@@ -52,7 +52,7 @@
     "@types/chai": "4.3.1",
     "@types/flatbuffers": "~1.10.0",
     "@types/node": "~18.16.20",
-    "@vitest/coverage-istanbul": "^2.1.0",
+    "@vitest/coverage-v8": "^2.1.0",
     "eslint": "^8.56.0",
     "nyc": "^15.1.0",
     "rimraf": "^3.0.2",

diff --git a/core/common/vitest.config.mts b/core/common/vitest.config.mts
@@ -3,7 +3,7 @@ export default defineConfig({
   test: {
     dir: "src",
     coverage: {
-      provider: "istanbul", // akin to nyc
+      provider: "v8",
       include: [
         "src/**/*"
       ],

diff --git a/core/geometry/package.json b/core/geometry/package.json
@@ -41,7 +41,7 @@
     "@itwin/eslint-plugin": "^4.0.2",
     "@types/flatbuffers": "~1.10.0",
     "@types/node": "~18.16.20",
-    "@vitest/coverage-istanbul": "^2.1.0",
+    "@vitest/coverage-v8": "^2.1.0",
     "eslint": "^8.56.0",
     "rimraf": "^3.0.2",
     "typescript": "~5.3.3",

diff --git a/core/geometry/vitest.config.mts b/core/geometry/vitest.config.mts
@@ -5,7 +5,7 @@ export default defineConfig({
     setupFiles: "./src/test/setupTests.ts",
     // include: ["**/filename.test.ts"], // to honor it/describe.only
     coverage: {
-      provider: "istanbul", // akin to nyc,
+      provider: "v8",
       include: [
         "src/**/*"
       ],