Do not draw box border when width is 0 (chartjs#342)

* Do not draw box border when width is 0 * Fix lint issues
santam85 · Mar 8, 2021 · e4fde33 · e4fde33
1 parent 67da887
commit e4fde33
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 1 deletion.
diff --git a/src/types/box.js b/src/types/box.js
@@ -33,7 +33,11 @@ export default class BoxAnnotation extends Element {
 
     roundedRect(ctx, x, y, width, height, options.cornerRadius);
     ctx.fill();
-    ctx.stroke();
+
+    // If no border, don't draw it
+    if (options.borderWidth) {
+      ctx.stroke();
+    }
 
     ctx.restore();
   }

diff --git a/test/fixtures/box/borderWidth0.js b/test/fixtures/box/borderWidth0.js
@@ -0,0 +1,38 @@
+module.exports = {
+  config: {
+    type: 'bar',
+    options: {
+      scales: {
+        x: {
+          labels: ['January', 'February', 'March', 'April', 'May', 'June', 'July'],
+        },
+        y: {
+          display: false,
+          min: 0,
+          max: 25
+        }
+      },
+      plugins: {
+        annotation: {
+          annotations: {
+            box1: {
+              type: 'box',
+              xScaleID: 'x',
+              yScaleID: 'y',
+              xMin: 1.5,
+              xMax: 3.5,
+              yMin: 5,
+              yMax: 10,
+              backgroundColor: 'rgba(33, 101, 171, 0.5)',
+              borderColor: 'red',
+              borderWidth: 0,
+            },
+          }
+        }
+      }
+    }
+  },
+  options: {
+    spriteText: true
+  }
+};
diff --git a/test/fixtures/box/borderWidth0.png b/test/fixtures/box/borderWidth0.png