Fix maxlength for token names (laravel#1300)

santycabg · Jun 19, 2020 · f984a7f · f984a7f
1 parent 63c8b66
commit f984a7f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Http/Controllers/ClientController.php b/src/Http/Controllers/ClientController.php
@@ -78,7 +78,7 @@ public function forUser(Request $request)
     public function store(Request $request)
     {
         $this->validation->make($request->all(), [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'redirect' => ['required', $this->redirectRule],
             'confidential' => 'boolean',
         ])->validate();
@@ -111,7 +111,7 @@ public function update(Request $request, $clientId)
         }
 
         $this->validation->make($request->all(), [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'redirect' => ['required', $this->redirectRule],
         ])->validate();
 

diff --git a/src/Http/Controllers/PersonalAccessTokenController.php b/src/Http/Controllers/PersonalAccessTokenController.php
@@ -61,7 +61,7 @@ public function forUser(Request $request)
     public function store(Request $request)
     {
         $this->validation->make($request->all(), [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'scopes' => 'array|in:'.implode(',', Passport::scopeIds()),
         ])->validate();
 

diff --git a/tests/Unit/ClientControllerTest.php b/tests/Unit/ClientControllerTest.php
@@ -58,7 +58,7 @@ public function test_clients_can_be_stored()
             'name' => 'client name',
             'redirect' => 'http://localhost',
         ], [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'redirect' => ['required', $redirectRule],
             'confidential' => 'boolean',
         ])->andReturn($validator);
@@ -97,7 +97,7 @@ public function test_public_clients_can_be_stored()
             'redirect' => 'http://localhost',
             'confidential' => false,
         ], [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'redirect' => ['required', $redirectRule],
             'confidential' => 'boolean',
         ])->andReturn($validator);
@@ -136,7 +136,7 @@ public function test_clients_can_be_updated()
             'name' => 'client name',
             'redirect' => 'http://localhost',
         ], [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'redirect' => ['required', $redirectRule],
         ])->andReturn($validator);
         $validator->shouldReceive('validate')->once();

diff --git a/tests/Unit/PersonalAccessTokenControllerTest.php b/tests/Unit/PersonalAccessTokenControllerTest.php
@@ -74,7 +74,7 @@ public function test_tokens_can_be_updated()
             'name' => 'token name',
             'scopes' => ['user', 'user-admin'],
         ], [
-            'name' => 'required|max:255',
+            'name' => 'required|max:191',
             'scopes' => 'array|in:'.implode(',', Passport::scopeIds()),
         ])->andReturn($validator);
         $validator->shouldReceive('validate')->once();