Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks the start of work to rebuild the proof of CreuSAT on a more modular and stable foundation.
I am adding a new
abstract-dpll
crate which will include the definitions and proofs related to the abstract dpll transition system documented in "Solving SAT and SAT Modulo Theories: From an abstract Davis--Putnam--Logemann--Loveland procedure to DPLL(T)" by Nieuwenhius, Oliveras and Tinelli.The objective will be to push most of the reaosning into this abstract system and limit the proofs about the concrete implementation to proofs of correspondence with the abstract system.
Actually building CreuSAT on this proof may end up requiring reimplementing it, but we'll see about that when we get there. The first step will be proving the soundness of abstract dpll.