Skip to content

Commit

Permalink
[SpotBugs]Enable spotbugs for module client-1x (apache#8798)
Browse files Browse the repository at this point in the history
  • Loading branch information
Renkai authored Dec 4, 2020
1 parent 4e8ca13 commit 4d160c0
Show file tree
Hide file tree
Showing 3 changed files with 54 additions and 13 deletions.
12 changes: 6 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -1344,12 +1344,12 @@ flexible messaging model and an intuitive client API.</description>
</goals>
<configuration>
<rules>
<requireJavaVersion>
<version>[1.8.0,)</version>
</requireJavaVersion>
<requireMavenVersion>
<version>[3.3.9,)</version>
</requireMavenVersion>
<requireJavaVersion>
<version>[1.8.0,)</version>
</requireJavaVersion>
<requireMavenVersion>
<version>[3.3.9,)</version>
</requireMavenVersion>
</rules>
</configuration>
</execution>
Expand Down
24 changes: 22 additions & 2 deletions pulsar-client-1x-base/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,27 @@
<packaging>pom</packaging>

<modules>
<module>pulsar-client-2x-shaded</module>
<module>pulsar-client-1x</module>
<module>pulsar-client-2x-shaded</module>
<module>pulsar-client-1x</module>
</modules>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
<executions>
<execution>
<id>spotbugs</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>
31 changes: 26 additions & 5 deletions pulsar-client-1x-base/pulsar-client-1x/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,36 @@
<artifactId>pulsar-client-2x-shaded</artifactId>
<version>${project.version}</version>
</dependency>

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>

<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
</dependency>
</dependencies>


<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>${spotbugs-maven-plugin.version}</version>
<executions>
<execution>
<id>spotbugs</id>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>

0 comments on commit 4d160c0

Please sign in to comment.