Skip to content

Commit

Permalink
reloc: stop removing entire BUILDDIR
Browse files Browse the repository at this point in the history
We found that user can mistakenly break system with --builddir option,
something like './reloc/build_deb.sh --builddir /'.
To avoid that we need to stop removing entire $BUILDDIR, remove
directories only we have to clean up before building deb package.

See: scylladb/scylla-python3#23 (comment)

Closes scylladb#9351
  • Loading branch information
syuu1228 authored and nyh committed Sep 19, 2021
1 parent cc8fc73 commit 5ab7fb7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion reloc/build_deb.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ if [ ! -e $RELOC_PKG ]; then
exit 1
fi
RELOC_PKG=$(readlink -f $RELOC_PKG)
rm -rf $BUILDDIR
rm -rf "$BUILDDIR"/scylla-package "$BUILDDIR"/scylla-package.orig "$BUILDDIR"/debian
mkdir -p $BUILDDIR/scylla-package
tar -C $BUILDDIR/scylla-package -xpf $RELOC_PKG
cd $BUILDDIR/scylla-package
Expand Down

0 comments on commit 5ab7fb7

Please sign in to comment.