Don't add class attribute for internal-facing classes

The class attribute is unneded for these classes, and this improves performance.
saurfang · Aug 29, 2014 · 6923a11 · 6923a11
1 parent 33d78fc
commit 6923a11
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 0 deletions.
diff --git a/R/cache.R b/R/cache.R
@@ -5,6 +5,7 @@
 CacheContext <- R6Class(
   'CacheContext',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .dirty = TRUE,
     # List of functions that return TRUE if dirty

diff --git a/R/fileupload.R b/R/fileupload.R
@@ -23,6 +23,7 @@
 FileUploadOperation <- R6Class(
   'FileUploadOperation',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .parent = NULL,
     .id = character(0),
@@ -81,6 +82,7 @@ FileUploadOperation <- R6Class(
 FileUploadContext <- R6Class(
   'FileUploadContext',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .basedir = character(0),
     .operations = 'Map',

diff --git a/R/map.R b/R/map.R
@@ -12,6 +12,7 @@
 Map <- R6Class(
   'Map',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .env = NULL,
 

diff --git a/R/middleware.R b/R/middleware.R
@@ -224,6 +224,7 @@ staticHandler <- function(root) {
 ## ------------------------------------------------------------------------
 HandlerList <- R6Class("HandlerList",
   portable = FALSE,
+  class = FALSE,
   public = list(
     handlers = list(),
 
@@ -258,6 +259,7 @@ HandlerList <- R6Class("HandlerList",
 
 HandlerManager <- R6Class("HandlerManager",
   portable = FALSE,
+  class = FALSE,
   public = list(
     handlers = "HandlerList",
     wsHandlers = "HandlerList",

diff --git a/R/priorityqueue.R b/R/priorityqueue.R
@@ -7,6 +7,7 @@
 PriorityQueue <- R6Class(
   'PriorityQueue',
   portable = FALSE,
+  class = FALSE,
   public = list(
     # Keys are priorities, values are subqueues (implemented as list)
     .itemsByPriority = 'Map',

diff --git a/R/react.R b/R/react.R
@@ -1,6 +1,7 @@
 Context <- R6Class(
   'Context',
   portable = FALSE,
+  class = FALSE,
   public = list(
     id = character(0),
     .label = character(0),      # For debug purposes
@@ -77,6 +78,7 @@ Context <- R6Class(
 ReactiveEnvironment <- R6Class(
   'ReactiveEnvironment',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .currentContext = NULL,
     .nextId = 0L,

diff --git a/R/reactives.R b/R/reactives.R
@@ -4,6 +4,7 @@ NULL
 Dependents <- R6Class(
   'Dependents',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .dependents = 'Map',
 

diff --git a/R/shiny.R b/R/shiny.R
@@ -178,6 +178,7 @@ NULL
 ShinySession <- R6Class(
   'ShinySession',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .websocket = 'ANY',
     .invalidatedOutputValues = 'Map',

diff --git a/R/stack.R b/R/stack.R
@@ -3,6 +3,7 @@
 Stack <- R6Class(
   'Stack',
   portable = FALSE,
+  class = FALSE,
   public = list(
 
     initialize = function(init = 20L) {

diff --git a/R/timer.R b/R/timer.R
@@ -7,6 +7,7 @@ now <- function() {
 TimerCallbacks <- R6Class(
   'TimerCallbacks',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .nextId = 0L,
     .funcs = 'Map',

diff --git a/R/utils.R b/R/utils.R
@@ -578,6 +578,7 @@ registerDebugHook <- function(name, where, label) {
 Callbacks <- R6Class(
   'Callbacks',
   portable = FALSE,
+  class = FALSE,
   public = list(
     .nextId = integer(0),
     .callbacks = 'Map',