Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update audioscrobbler.liq #4271

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Update audioscrobbler.liq #4271

merged 2 commits into from
Dec 15, 2024

Conversation

gAlleb
Copy link
Contributor

@gAlleb gAlleb commented Dec 14, 2024

Defining timestamp as time() in audioscrobbler.api.track.scrobble function makes time freeze and show the same time for all scrobbled tracks.

Снимок экрана 2024-12-14 в 20 20 26

All of the above tracks have been played through from start to finish. But all of them are scrobbled at the exact same time/time ago. It is the time when first track has been scrobbled since the start of LS session.

Using time() right inside params fixes it.

 params =
    [
      ("track", track),
      ("artist", artist),
      ("timestamp", string(time())),
...

#4250 (comment)

gAlleb and others added 2 commits December 15, 2024 00:24
Defining timestamp as `time()` in `audioscrobbler.api.track.scrobble` function makes it freeze and show the same time for all scrobbled tracks. Using `time()` right inside `params` fixes it.
@toots
Copy link
Member

toots commented Dec 15, 2024

Thanks!

@toots toots enabled auto-merge December 15, 2024 08:52
@toots toots added this pull request to the merge queue Dec 15, 2024
Merged via the queue into savonet:main with commit 95fb55b Dec 15, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants