Cleaning up

sawano · Mar 25, 2017 · 44959c7 · 44959c7
1 parent ebbd146
commit 44959c7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/se/sawano/java/security/otp/SharedSecret.java b/src/main/java/se/sawano/java/security/otp/SharedSecret.java
@@ -32,7 +32,8 @@
 import static org.apache.commons.lang3.Validate.notNull;
 
 /**
- * RFC4226 requires a shared secret with minimum length of 128 bits. And recommends the secret to be at leas 160 bits (20 bytes). This class requires the secret to be at least 20 bytes.
+ * RFC4226 requires a shared secret with minimum length of 128 bits. And recommends the secret to be at leas 160 bits (20 bytes). This class takes an opinionated view and requires the secret to be at
+ * least 20 bytes.
  */
 public final class SharedSecret implements Externalizable {
 

diff --git a/src/main/java/se/sawano/java/security/otp/impl/DefaultSecretService.java b/src/main/java/se/sawano/java/security/otp/impl/DefaultSecretService.java
@@ -38,7 +38,7 @@ public DefaultSecretService(final RandomSupplier random) {
         notNull(random);
 
         this.random = random;
-        // TODO consolidate with SharedSecret?
+        // TODO review these lengths
         algorithmToNumberOfBytes.put(ShaAlgorithm.SHA1, 20);
         algorithmToNumberOfBytes.put(ShaAlgorithm.SHA256, 32);
         algorithmToNumberOfBytes.put(ShaAlgorithm.SHA512, 64);