Merge branch 'MDL-401-master_brief_name' of https://github.com/olivie…

…rvalentin/moodle
sbourget · Oct 31, 2023 · 70d0295 · 70d0295
2 parents 5059461 + 634d1a3
commit 70d0295
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/report/configlog/classes/reportbuilder/local/entities/config_change.php b/report/configlog/classes/reportbuilder/local/entities/config_change.php
@@ -172,6 +172,16 @@ protected function get_all_filters(): array {
                 date::DATE_CURRENT,
             ]);
 
+        // Plugin filter.
+        $filters[] = (new filter(
+            text::class,
+            'plugin',
+            new lang_string('plugin', 'report_configlog'),
+            $this->get_entity_name(),
+            "COALESCE({$tablealias}.plugin, 'core')"
+        ))
+            ->add_joins($this->get_joins());
+
         // Setting filter.
         $filters[] = (new filter(
             text::class,

diff --git a/report/configlog/classes/reportbuilder/local/systemreports/config_changes.php b/report/configlog/classes/reportbuilder/local/systemreports/config_changes.php
@@ -103,6 +103,7 @@ protected function add_columns(): void {
      */
     protected function add_filters(): void {
         $filters = [
+            'config_change:plugin',
             'config_change:setting',
             'config_change:value',
             'config_change:oldvalue',

diff --git a/report/configlog/tests/behat/view_report.feature b/report/configlog/tests/behat/view_report.feature
@@ -37,6 +37,7 @@ Feature: In a report, admin can see configuration changes
     And I should not see "<excluded>" in the "reportbuilder-table" "table"
     Examples:
       | field     | search              | plugin | setting             | value  | excluded            |
+      | Plugin    | folder              | folder | maxsizetodownload   | 2048   | quiz                |
       | Setting   | initialnumfeedbacks | quiz   | initialnumfeedbacks | 5      | maxsizetodownload   |
       | Setting   | maxsizetodownload   | folder | maxsizetodownload   | 2048   | initialnumfeedbacks |
       | New value | Perth               | core   | defaultcity         | Perth  | maxsizetodownload   |