MDL-78288 core_course: Hide access restrictions textarea till ready

sbourget · Jul 12, 2023 · 841d552 · 841d552
1 parent 6c1471c
commit 841d552
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 6 deletions.
diff --git a/availability/yui/build/moodle-core_availability-form/moodle-core_availability-form-debug.js b/availability/yui/build/moodle-core_availability-form/moodle-core_availability-form-debug.js
@@ -145,6 +145,10 @@ M.core_availability.form = {
             }
             this.updateRestrictByGroup();
         }
+
+        // Everything is ready. Make sure the div is visible.
+        this.parent = Y.one('#fitem_id_availabilityconditionsjson');
+        this.parent.removeClass('d-none');
     },
 
     /**

diff --git a/availability/yui/build/moodle-core_availability-form/moodle-core_availability-form-min.js b/availability/yui/build/moodle-core_availability-form/moodle-core_availability-form-min.js
diff --git a/availability/yui/build/moodle-core_availability-form/moodle-core_availability-form.js b/availability/yui/build/moodle-core_availability-form/moodle-core_availability-form.js
@@ -145,6 +145,10 @@ M.core_availability.form = {
             }
             this.updateRestrictByGroup();
         }
+
+        // Everything is ready. Make sure the div is visible.
+        this.parent = Y.one('#fitem_id_availabilityconditionsjson');
+        this.parent.removeClass('d-none');
     },
 
     /**

diff --git a/availability/yui/src/form/js/form.js b/availability/yui/src/form/js/form.js
@@ -143,6 +143,10 @@ M.core_availability.form = {
             }
             this.updateRestrictByGroup();
         }
+
+        // Everything is ready. Make sure the div is visible.
+        this.parent = Y.one('#fitem_id_availabilityconditionsjson');
+        this.parent.removeClass('d-none');
     },
 
     /**

diff --git a/course/editsection_form.php b/course/editsection_form.php
@@ -57,7 +57,9 @@ function definition() {
             // interaction is all implemented in JavaScript. The field is named
             // availabilityconditionsjson for consistency with moodleform_mod.
             $mform->addElement('textarea', 'availabilityconditionsjson',
-                get_string('accessrestrictions', 'availability'));
+                get_string('accessrestrictions', 'availability'),
+                ['class' => 'd-none']
+            );
         }
 
         $mform->_registerCancelButton('cancel');

diff --git a/course/moodleform_mod.php b/course/moodleform_mod.php
@@ -712,7 +712,10 @@ protected function standard_coursemodule_elements() {
             // conflicts with fields in existing modules (such as assign).
             // So it uses a long name that will not conflict.
             $mform->addElement('textarea', 'availabilityconditionsjson',
-                    get_string('accessrestrictions', 'availability'));
+                    get_string('accessrestrictions', 'availability'),
+                    ['class' => 'd-none']
+            );
+
             // The _cm variable may not be a proper cm_info, so get one from modinfo.
             if ($this->_cm) {
                 $modinfo = get_fast_modinfo($COURSE);