MDL-44653 mod_feedback - Include additional name fields using user_pi…

…cture::fields()
sbourget · Mar 18, 2014 · e68fc3c · e68fc3c
1 parent efd7270
commit e68fc3c
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/mod/feedback/lib.php b/mod/feedback/lib.php
@@ -385,11 +385,11 @@ function feedback_get_recent_mod_activity(&$activities, &$index,
 
     $sqlargs = array();
 
-    //TODO: user user_picture::fields;
-    $sql = " SELECT fk . * , fc . * , u.firstname, u.lastname, u.email, u.picture, u.email
-                                            FROM {feedback_completed} fc
-                                                JOIN {feedback} fk ON fk.id = fc.feedback
-                                                JOIN {user} u ON u.id = fc.userid ";
+    $userfields = user_picture::fields('u', null, 'userid');
+    $sql = " SELECT fk . * , fc . * , $userfields
+                FROM {feedback_completed} fc
+                    JOIN {feedback} fk ON fk.id = fc.feedback
+                    JOIN {user} u ON u.id = fc.userid ";
 
     if ($groupid) {
         $sql .= " JOIN {groups_members} gm ON  gm.userid=u.id ";