Fix StringSequence.equals() for different lengths

See spring-projectsgh-15465
sbrannen · Dec 17, 2018 · 2a0680c · 2a0680c
1 parent 64c6b9c
commit 2a0680c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/.../spring-boot-loader/src/main/java/org/springframework/boot/loader/jar/StringSequence.java b/.../spring-boot-loader/src/main/java/org/springframework/boot/loader/jar/StringSequence.java
@@ -126,7 +126,7 @@ public boolean equals(Object obj) {
 			}
 			return true;
 		}
-		return true;
+		return false;
 	}
 
 	@Override

diff --git a/...ng-boot-loader/src/test/java/org/springframework/boot/loader/jar/StringSequenceTests.java b/...ng-boot-loader/src/test/java/org/springframework/boot/loader/jar/StringSequenceTests.java
@@ -167,6 +167,13 @@ public void equalsWhenSameContentShouldMatch() {
 		assertThat(a).isEqualTo(b).isNotEqualTo(c);
 	}
 
+	@Test
+	public void notEqualsWhenSequencesOfDifferentLength() {
+		StringSequence a = new StringSequence("abcd");
+		StringSequence b = new StringSequence("ef");
+		assertThat(a).isNotEqualTo(b);
+	}
+
 	@Test
 	public void startsWithWhenExactMatch() {
 		assertThat(new StringSequence("abc").startsWith("abc")).isTrue();