Skip to content

Commit

Permalink
fix(*): force tags in Makefiles
Browse files Browse the repository at this point in the history
When running `make build`, sometimes components fail to build,
aborting the Makefile run. After fixing the issue, building again,
and running `make dev-release`, some components
have already been tagged and emit an error like "Tag asdf already
references image bcde".

This commit makes `docker tag` force the tag, preventing
a semi-successful build from preventing releases.
  • Loading branch information
carmstrong committed Feb 3, 2015
1 parent 1861a9d commit 76c5b0e
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion builder/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion cache/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion controller/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion database/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion logger/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion logspout/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(RELEASE_IMAGE) $(DEV_DOCKER_IMAGE)
docker tag -f $(RELEASE_IMAGE) $(DEV_DOCKER_IMAGE)
docker push $(DEV_DOCKER_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion publisher/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ install: check-deisctl
dev-release: push set-image

push: check-registry
docker tag $(RELEASE_IMAGE) $(REMOTE_IMAGE)
docker tag -f $(RELEASE_IMAGE) $(REMOTE_IMAGE)
docker push $(REMOTE_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion registry/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
2 changes: 1 addition & 1 deletion router/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(IMAGE) $(DEV_IMAGE)
docker tag -f $(IMAGE) $(DEV_IMAGE)
docker push $(DEV_IMAGE)

set-image: check-deisctl
Expand Down
10 changes: 5 additions & 5 deletions store/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -70,15 +70,15 @@ run: install start
dev-release: push set-image

push: check-registry
docker tag $(ADMIN_IMAGE) $(ADMIN_DEV_IMAGE)
docker tag -f $(ADMIN_IMAGE) $(ADMIN_DEV_IMAGE)
docker push $(ADMIN_DEV_IMAGE)
docker tag $(DAEMON_IMAGE) $(DAEMON_DEV_IMAGE)
docker tag -f $(DAEMON_IMAGE) $(DAEMON_DEV_IMAGE)
docker push $(DAEMON_DEV_IMAGE)
docker tag $(GATEWAY_IMAGE) $(GATEWAY_DEV_IMAGE)
docker tag -f $(GATEWAY_IMAGE) $(GATEWAY_DEV_IMAGE)
docker push $(GATEWAY_DEV_IMAGE)
docker tag $(METADATA_IMAGE) $(METADATA_DEV_IMAGE)
docker tag -f $(METADATA_IMAGE) $(METADATA_DEV_IMAGE)
docker push $(METADATA_DEV_IMAGE)
docker tag $(MONITOR_IMAGE) $(MONITOR_DEV_IMAGE)
docker tag -f $(MONITOR_IMAGE) $(MONITOR_DEV_IMAGE)
docker push $(MONITOR_DEV_IMAGE)

set-image: check-deisctl
Expand Down

0 comments on commit 76c5b0e

Please sign in to comment.