Skip to content

Commit

Permalink
Merge pull request jazzband#314 from davidszotten/reverse_dep_case
Browse files Browse the repository at this point in the history
dep cache uses lowercase keys
  • Loading branch information
nvie committed Feb 5, 2016
2 parents 3a2de92 + 2b925f1 commit 494aa6b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion piptools/writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def _format_requirement(self, ireq, reverse_dependencies, primary_packages, incl
return line

# Annotate what packages this package is required by
required_by = reverse_dependencies.get(ireq.name, [])
required_by = reverse_dependencies.get(ireq.name.lower(), [])
if required_by:
line = line.ljust(24)
annotation = ', '.join(sorted(required_by))
Expand Down
10 changes: 10 additions & 0 deletions tests/test_writer.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,16 @@ def test_format_requirement_annotation(from_line, writer):
'test==1.2 ' + comment(' # via xyz'))


def test_format_requirement_annotation_case_sensitive(from_line, writer):
ireq = from_line('Test==1.2')
reverse_dependencies = {'test': ['xyz']}

assert (writer._format_requirement(ireq,
reverse_dependencies,
primary_packages=[]) ==
'Test==1.2 ' + comment(' # via xyz'))


def test_format_requirement_not_for_primary(from_line, writer):
"Primary packages should not get annotated."
ireq = from_line('test==1.2')
Expand Down

0 comments on commit 494aa6b

Please sign in to comment.