Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Commit

Permalink
[#980834] Ensure proto properties can be redefined.
Browse files Browse the repository at this point in the history
  • Loading branch information
ScottDowne committed Mar 12, 2014
1 parent a7e0d2c commit c265a58
Showing 1 changed file with 24 additions and 12 deletions.
36 changes: 24 additions & 12 deletions wrappers/common/popcorn._MediaElementProto.js
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@
currentSrc: {
get: function() {
return this.src !== undefined ? this.src : "";
}
},
configurable: true
},

parentNode: {
Expand All @@ -156,48 +157,55 @@
},
set: function( val ) {
parentNode = val;
}
},
configurable: true
},

// We really can't do much more than "auto" with most of these.
preload: {
get: function() {
return "auto";
},
set: Popcorn.nop
set: Popcorn.nop,
configurable: true
},

controls: {
get: function() {
return true;
},
set: Popcorn.nop
set: Popcorn.nop,
configurable: true
},

// TODO: it would be good to overlay an <img> using this URL
poster: {
get: function() {
return "";
},
set: Popcorn.nop
set: Popcorn.nop,
configurable: true
},

crossorigin: {
get: function() {
return "";
}
},
configurable: true
},

played: {
get: function() {
return _fakeTimeRanges;
}
},
configurable: true
},

seekable: {
get: function() {
return _fakeTimeRanges;
}
},
configurable: true
},

buffered: {
Expand All @@ -210,25 +218,29 @@
defaultMuted: {
get: function() {
return false;
}
},
configurable: true
},

defaultPlaybackRate: {
get: function() {
return 1.0;
}
},
configurable: true
},

style: {
get: function() {
return this.parentNode.style;
}
},
configurable: true
},

id: {
get: function() {
return this.parentNode.id;
}
},
configurable: true
}

// TODO:
Expand Down

0 comments on commit c265a58

Please sign in to comment.