Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use license_files in setup.cfg #1883

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Jun 10, 2022

Description

Use license_files over license_file in setup.cfg to avoid

SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use license_files instead.

setuptools added support for license_files in v42.0.0.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use 'license_files' over 'license_file' in setup.cfg to avoid
'SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use
license_files instead.' setuptools added support for 'license_files' in v42.0.0.

* Use 'license_files' over 'license_file' in setup.cfg to avoid
'SetuptoolsDeprecationWarning: The license_file parameter is deprecated, use
license_files instead.' setuptools added support for 'license_files' in v42.0.0.
@matthewfeickert matthewfeickert added build Changes that affect the build system or external dependencies packaging setup.py, setup.cfg, pyproject.toml, and friends labels Jun 10, 2022
@matthewfeickert matthewfeickert self-assigned this Jun 10, 2022
@matthewfeickert
Copy link
Member Author

Once I understand pypa/build#482 better I'll also add a check to the CI workflow so that these get caught automatically.

@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1883 (390f6b9) into master (ebcc964) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1883   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.39% <ø> (ø)
doctest 60.73% <ø> (ø)
unittests-3.10 96.04% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebcc964...390f6b9. Read the comment docs.

@matthewfeickert
Copy link
Member Author

As other maintainers are on holiday, I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 86229ad into master Jun 10, 2022
@matthewfeickert matthewfeickert deleted the build/use-license_files branch June 10, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies packaging setup.py, setup.cfg, pyproject.toml, and friends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant