Added backup() method to backup shortcuts.vdf before saving it #195
Conversation
|
Awesome, thanks for doing this. I do have a few quick requests though before I merge it, comments inline. |
| # If they just called backup(), then overwrite the file that was used to | ||
| # generate the manager. | ||
| if not file: | ||
| file = self.shortcuts_file |
There was a problem hiding this comment.
I dont think file is a great parameter. It doesn't make sense to me that a shortcut manager can backup any file on the users system. If the shortcut manager is going to have back something up, it should be the shortcuts file and the shortcuts file only. I would prefer file was removed as a parameter and these two lines were changed to
if not self.shortcuts_file:
return
There was a problem hiding this comment.
I was following what was laid out by the save method. The file parameter should be removed from there as well, as it can currently overwrite any file on the user's system with a generated shortcuts file. I do agree though, and I will change it when I get home from work.
Fixed comment Changed backup() to use config file for the location and made it only possible to backup the shortcuts file
|
Updated and squashed the commits. |
Added backup() method to backup shortcuts.vdf before saving it
This will backup each user's shortcuts.vdf file before saving the new one generated by Ice. The backups are saved to the folder "userdata/user_id/config/backups" with a timestamp.